-
Notifications
You must be signed in to change notification settings - Fork 2.4k
new icon: delphi (original, plain) #2290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Excellent work on the icon. If possible could you also create a plain version of the icon? Here is how a plain icon should look like. |
…into new-icon-delphi-12
Added logo in plain version |
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
@canaleal Can you review this PR, now everything is ok |
@Snailedlt Opinions on the original.svg? It had a lot of paths and I don't think there's a way to optimize it. |
Hmm, if you're not able to optimize it I doubt I'll be able to do it. Maybe the guy from nerdfonts would be able to help here? I know he is good at optimizing the number of nodes. @Finii do you have any tips for us to optimize this icon? Would be nice if it was properly optimized here, so you don't have to re-optimize it for usage in nerdfonts |
Hej ;)
In Inkscape, select all, Removed this tiny (probably unwanted) path first: And then the fill was concrete colors for each path, different colors 🤔 In the simple version you probably want no concrete color at all, select 'filled with unknown color' and probably 'evenodd fill', and 'no stroke'. Fonts always work with
And then I guess there are too many nodes, optimized them away. Here the Here I simplified all nodes except the outer circle which is already optimal with 4 nodes at the extrema. Left side 131 nodes, right side 347 nodes And finally ... $ ll delphi-plain*
-rw-rw-r-- 1 fini fini 10770 Feb 10 10:46 delphi-plain_orig.svg
-rw-rw-r-- 1 fini fini 4886 Feb 10 12:12 delphi-plain.svg Here's the file:
Edit: Hmm, I was wrong with the fill rules. Maybe it depends on being a postscript based (otf) font or a truetype (ttf) font, but I know that sometimes I have to correct the path direction to get the correct fill in the resulting font file. And that only makes sense if the font uses nonzero. 🤔 Changed the advice given above and also changed the attached svg. Origin of snippet: https://www.w3.org/TR/SVG/painting.html#FillProperties |
@Finii thanks a bunch! I'm glad we have such a knowledgeable developer we can reach out to for help! @canaleal I think these should be good, just make sure you double check that the plain versions render correctly on icomoon :) |
Hobbyist 😬
2000 path with maybe 300 nodes each 😬 The reason is that the fill is with gradients, but the gradients are in fact just a lot of individual paths all filled with one solid color (red), slightly different from the path nearby. Top of the icon zoomed way in Note all the single colored areas, and how 'unclean' the darkred wedge comes in 😬 But here I have no clue how to optimize it while keeping the coloring true to the original. A 'regular' gradient is how it is and can not be tweaked with infinite precision. One would need to define which 'imperfections' or 'deviations from the original' or still ok. 🤔 I am not even sure what the aim of the different svgs here is, maybe to be consumed as svgs, and as such that is probably all good. Otoh, the more I look at icons, the more I wonder WHO create the original svgs, probably graphic designers that do not care and/or understand how that all 'really' works. Like me 1992 with Corel Draw 2 🤣 |
Yeah, it was probably made with some workarounds in a tool that wasn't made for gradients I guess. Perhaps we should ask the delphi developers if we can remake the icon with a simplified gradient. I bet they would also appreciate a more optimized version |
@gewaleelek that looks very good in my opinion, but I think we should contact the delphi team to hear what they think. Maybe they have a very clever way to optimize the icon already :) @sgratzl perhaps you have some input here? |
any updates? |
Should this be made more clear that this not Delphi, the company? https://www.delphiautoparts.com/ |
Afraid not |
I'm just wondering but is the person you tagged involved with Delphi (the IDE)? Their profile mentions them being in the "Delphi" group, but that Delphi seems to be related to healthcare data for infectious diseases, not the commercial Object Pascal IDE. |
@gewaleelek ohh, it seems your right. |
Unfortunately no. This PR is the first time I've heard of this tool, actually. There's a contact email on their website, at least. In my humble opinion, with the officially provided "vector" looking like it was just converted from a raster image instead of the other way around, I can't help but wonder if their response will be any helpful at all. |
Official website: https://www.embarcadero.com/ And i got the logo in: https://www.embarcadero.com/news/logo |
@Bulani did you make the original svg from the PNG or EPS version on the website? |
@Snailedlt I got the .epg and convert to .svg, and a used the guides: https://github.com/devicons/devicon/wiki/Creating-original-Icons |
@Bulani okey, great. That's the right way to do it :) I was just trying to understand if the color banding on the gradients was a result of the conversion to SVG or not, but if it was converted from eps I think the color banding is also in the original icon. The original icon is over 1.2 million characters long 😅 I suggest we use the optimized version created by @gewaleelek so that the size of the icon is manageable. |
Optimized version of the one created by @gewaleelek here: devicons#2290 (comment) Co-authored-by: gewaleelek <165679471+gewaleelek@users.noreply.github.com>
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
1 similar comment
Hi! I'm the
Check our CONTRIBUTING guide for more details regarding these errors. Please address these issues. When you update this PR, I will check your SVGs again. Thanks for your help, |
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty of adding an optimized version of the icon made by @gewaleelek, and with that I believe the PR is finished!
congrats and thanks to both @Bulani, @gewaleelek and @Finii for a great contribution! 🙇♂️
LGTM ✔️
whoopsie. Seems I did not check the plain icon well enough. Reverted. I'll create a new PR Edit: new PR here -> #2429 |
* new icon: delphi-12 (original) * new icon: delphi-12 (original) * new icon: delphi (original) * Add plain icon * Optimizing icons * Add optimized version created by @gewaleelek Optimized version of the one created by @gewaleelek here: #2290 (comment) Co-authored-by: gewaleelek <165679471+gewaleelek@users.noreply.github.com> * Update delphi-plain.svg * update color to the same as the plain icon --------- Co-authored-by: Bulani <jao_1999@hotmail.com> Co-authored-by: gewaleelek <165679471+gewaleelek@users.noreply.github.com>
Double check these details before you open a PR
develop
branch.devicon.json
file at the correct alphabetic position as seen hereThis PR closes NONE
Link to prove your SVG is correct and up-to-date.
https://www.embarcadero.com/br/news/logo