Skip to content

new icon: hoppscotch (original, plain) #2281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 16, 2025
Merged

new icon: hoppscotch (original, plain) #2281

merged 6 commits into from
Feb 16, 2025

Conversation

Tiger-Tig74
Copy link
Contributor

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes #2277

Link to prove your SVG is correct and up-to-date.

https://github.com/hoppscotch/hoppscotch

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

canaleal
canaleal previously approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work. 👍

The icons are good and there are no artifacts in icomoon.

image

@canaleal canaleal requested review from a team, ConX, weh, Snailedlt and lunatic-fox and removed request for a team October 13, 2024 05:06
weh
weh requested changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some newlines missing. Newlines should be added for older Editors.

@Tiger-Tig74 @weh
Update icons/hoppscotch/hoppscotch-original.svg
dd4140b 
Co-authored-by: Patrik Wehrli <patrik.wehrli@gmail.com>
@Tiger-Tig74 @weh
Update icons/hoppscotch/hoppscotch-plain.svg
d60e182 
Co-authored-by: Patrik Wehrli <patrik.wehrli@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal changed the title new icon: hoppscotch (plain, original) new icon: hoppscotch (original, plain) Oct 14, 2024
@canaleal canaleal added the feature:icon PR when a new icon is ready to be added to the collection label Nov 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

weh
weh approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@weh weh requested a review from canaleal January 15, 2025 10:37
@github-actions GitHub Actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit b32fd51 into devicons:develop Feb 16, 2025
5 checks passed
@canaleal canaleal mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weh weh weh approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@Snailedlt Snailedlt Awaiting requested review from Snailedlt Snailedlt was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

@canaleal canaleal Awaiting requested review from canaleal

Assignees
No one assigned
Labels
feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tiger-Tig74 @weh @canaleal