Skip to content

new icon: memcached (original) #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 26, 2024
Merged

new icon: memcached (original) #2273

merged 3 commits into from
Dec 26, 2024

Conversation

inpour
Copy link
Contributor

@inpour inpour commented Sep 22, 2024

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #2271

Link to prove your SVG is correct and up-to-date.

https://memcached.org/

@inpour inpour force-pushed the new-icon-memcached branch 2 times, most recently from c25bb7e to dea4116 Compare October 8, 2024 10:51
canaleal
canaleal previously requested changes Nov 3, 2024
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to devicons 👍

I've left some comments on how to improve the MR. If you have any questions or need help feel free to ask!

@canaleal canaleal added the feature:icon PR when a new icon is ready to be added to the collection label Nov 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal
Copy link
Member

canaleal commented Dec 7, 2024

Hey @inpour. Hope you don't mind but I've added the plain and line versions of the icon.

@canaleal
Copy link
Member

canaleal commented Dec 7, 2024

There are no weird artifacts in the SVGs.

image

@canaleal canaleal dismissed their stale review December 7, 2024 22:27

Issues resolved

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@inpour
Copy link
Contributor Author

inpour commented Dec 11, 2024

All good, Thank you @canaleal .

@inpour inpour force-pushed the new-icon-memcached branch from d7de88a to 6e3e7fe Compare December 11, 2024 09:09
@github-actions GitHub Actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@github-actions GitHub Actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit 88f1992 into devicons:develop Dec 26, 2024
5 checks passed
@canaleal canaleal mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@canaleal canaleal canaleal approved these changes

Assignees
No one assigned
Labels
feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inpour @canaleal