Skip to content

new icon: discloud (original, original-wordmark, plain-wordmark) #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 10, 2024
Merged

new icon: discloud (original, original-wordmark, plain-wordmark) #2206

merged 2 commits into from
Nov 10, 2024

Conversation

canaleal
Copy link
Member

@canaleal canaleal commented Jun 8, 2024

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #2143

Link to prove your SVG is correct and up-to-date.

Line versions were not created as discloud does not approve of such changes as mentioned in their branding guide.
The color #57f287 was selected for the font SVGs as it's the main Go Discloud color.

@canaleal canaleal added the feature:icon PR when a new icon is ready to be added to the collection label Jun 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 8, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

weh
weh approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@weh weh requested review from a team, ConX, Snailedlt and lunatic-fox and removed request for a team June 11, 2024 13:53
@github-actions GitHub Actions
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal
Copy link
Member Author

No artifacts in the font SVGs.

image

image

@canaleal canaleal merged commit fbd10f6 into devicons:develop Nov 10, 2024
5 checks passed
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
@canaleal
Merge pull request devicons#2206 from canaleal/new-icon-discloud
673522d 
new icon: discloud (original, original-wordmark, plain-wordmark)
@canaleal canaleal mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weh weh weh approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@Snailedlt Snailedlt Awaiting requested review from Snailedlt Snailedlt was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

Assignees
No one assigned
Labels
feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@canaleal @weh