Skip to content

Conversation

canaleal
Copy link
Member

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR is related to #1998

Link to prove your SVG is correct and up-to-date.

Additional Notes

I was unable to find an official mark logo without the protractor text. As such, I used aliases for all the wordmark versions.
The red color #d51c2f was used for the font SVGs. This color is taken from the lighter red on the protractor-original svg.

@canaleal canaleal added the feature:icon PR when a new icon is ready to be added to the collection label Nov 29, 2023
lunatic-fox
lunatic-fox previously approved these changes Nov 30, 2023
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great one! 👍🏼
Thank you for this contribution! 🚀
PS: Seems that SVG logo has different colors from PNG one, I mean, the original version.
image
image

@lunatic-fox lunatic-fox requested review from a team, ConX and weh and removed request for a team December 5, 2023 03:47
Snailedlt
Snailedlt previously approved these changes Dec 5, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job once again!
The only place I could find the non-wordmark version was in the favicon... but not sure that should count, since it's only used as the website icon here:
image
https://www.protractortest.org/img/favicon.ico

@Snailedlt
Copy link
Collaborator

@canaleal Once again I'll let you choose whether or not you wanna merge, or add the non-wordmark version(s)

@canaleal
Copy link
Member Author

canaleal commented Dec 5, 2023

I'm gonna add the non-wordmark version.

@canaleal canaleal dismissed stale reviews from Snailedlt and lunatic-fox via 9fb3374 December 6, 2023 00:31
@lunatic-fox lunatic-fox changed the title update icon: protractor (original, plain, line) update icon: protractor (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) Dec 7, 2023
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image
image
image

@lunatic-fox lunatic-fox requested a review from Snailedlt December 7, 2023 23:08
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✔️
Looks Great! 💯 Thank you for another great PR! 🙇‍♂️

@Snailedlt Snailedlt merged commit 76bfb05 into devicons:develop Dec 17, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
…rdmark, line, line-wordmark) (devicons#2077)

* update icon protractor

* Added mark svgs for protractor

---------

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants