Skip to content

Conversation

canaleal
Copy link
Member

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR is related to #1998

Link to prove your SVG is correct and up-to-date.

Additional Notes

Some wordmarks have the TM (Trade Mark) text; I went with the version without the TX.
The purple color #782a90 was used for the font SVGs.

@canaleal canaleal added the feature:icon PR when a new icon is ready to be added to the collection label Nov 22, 2023
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still need the trademark symbol since the official logo has that. 🤔
vertx

@lunatic-fox lunatic-fox changed the title update icon: vertx (original, original-wordmark, plain-wordmark, line, line-wordmark) update icon: vertx (original, original-wordmark, plain, plain-wordmark, line, line-wordmark) Dec 7, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you made some typos on the color code for a few of the icons. Other than that it looks great!
image
image
image
image

lunatic-fox and others added 4 commits December 7, 2023 13:21
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
@lunatic-fox lunatic-fox requested a review from Snailedlt December 7, 2023 16:23
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍🏼
And thank you @Snailedlt for noticing the wrong color.
Thank for this contribution! 🚀

@Snailedlt Snailedlt merged commit 097d1cf into devicons:develop Dec 17, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
…k, line, line-wordmark) (devicons#2045)

* update icon: vertx

* Updated wordmark elements

* Adjusting icons and create `plain` version

* Update icons/vertx/vertx-plain.svg

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* Update icons/vertx/vertx-original.svg

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* Update icons/vertx/vertx-line.svg

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

* Update devicon.json

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>

---------

Co-authored-by: Josélio de S. C. Júnior <76992016+lunatic-fox@users.noreply.github.com>
Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants