Skip to content

Conversation

weh
Copy link
Contributor

@weh weh commented Nov 15, 2023

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened

Features

  • Replace gatsby plain by alias
  • Add newlines

This PR closes NONE

related to #2001

Notes

@weh weh requested review from a team, ConX, Snailedlt, canaleal and lunatic-fox and removed request for a team November 15, 2023 15:49
@weh weh mentioned this pull request Nov 15, 2023
9 tasks
@weh weh changed the title Replace plain by alias update icon: gatsby (original, original-wordmark, plain-wordmark) Nov 15, 2023
@canaleal canaleal added the feature:icon PR when a new icon is ready to be added to the collection label Nov 18, 2023
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for another great contribution! 💯
image
image
image

Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, upon closer inspection it looks like there's a bit of padding on the sides (left and right) of the wordmark versions:
image
image

This padding should be removed. Other than that everything looks perfect!

@weh
Copy link
Contributor Author

weh commented Nov 20, 2023

removed padding, and rebased to current develop branch

@weh weh requested a review from Snailedlt November 20, 2023 10:52
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Now we just need to re-optimize the icons (see my suggestions), and we're good to go! 🚀

@weh weh requested a review from Snailedlt November 22, 2023 14:05
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍🏼
Thank you for this contribution! 🚀

@Snailedlt Snailedlt merged commit 8e94fcb into devicons:develop Nov 25, 2023
@Snailedlt Snailedlt mentioned this pull request Feb 5, 2024
GCHQDeveloper926 pushed a commit to GCHQDeveloper926/devicon that referenced this pull request Dec 20, 2024
…vicons#2006)

* Replace plain by alias

* Add missing newlines

* Remove padding

* Update optimized svg

---------

Co-authored-by: Jørgen Kalsnes Hagen <43886029+Snailedlt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon PR when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants