fix: update node-fetch to 3.x #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node-fetch is now ESM module only, thus this will be a breaking change and will requires at least Node.js 12.20.0. As suggested[1] by `node-fetch`, async import() function is used to load `node-fetch` asynchronously. BREAKING CHANGE: requires at least node 12.20.0 [1]: https://github.com/node-fetch/node-fetch#commonjs
|
@developit , test cases are failing for me and I am stuck in one of the test case where |
|
Hope you take a look @developit |
developit
added a commit
that referenced
this pull request
Dec 31, 2022
kodiakhq bot
referenced
this pull request
in X-oss-byte/Nextjs
Oct 16, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [unfetch](https://togithub.com/developit/unfetch) | [`4.2.0` -> `5.0.0`](https://renovatebot.com/diffs/npm/unfetch/4.2.0/5.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>developit/unfetch (unfetch)</summary> ### [`v5.0.0`](https://togithub.com/developit/unfetch/releases/tag/5.0.0) [Compare Source](https://togithub.com/developit/unfetch/compare/4.2.0...5.0.0) #### What's Changed - Add TypeScript definitions and export them [@​developit](https://togithub.com/developit) in [https://github.com/developit/unfetch/pull/159](https://togithub.com/developit/unfetch/pull/159) - Add [Package Exports](https://togithub.com/developit/unfetch/blob/ed9469aab15e2cd8c243995a8ba964599467e413/package.json#L16-L26) to both unfetch and isomorphic-unfetch #### New Contributors - [@​RishikeshDarandale](https://togithub.com/RishikeshDarandale) made their first contribution to isomorphic-unfetch in [https://github.com/developit/unfetch/pull/156](https://togithub.com/developit/unfetch/pull/156) **Full Changelog**: developit/unfetch@4.2.0...5.0.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Nextjs).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-fetch is now ESM module only, thus this will be a breaking change and will requires at least Node.js 12.20.0.
As suggested by
node-fetch, async import() function is used to loadnode-fetchasynchronously.BREAKING CHANGE: requires at least node 12.20.0
Related:
#143
#154