- '#Content of method "shouldSkipArg\(\)" is duplicated with method "shouldSkipArg\(\)" in "Symplify\\PHPStanRules\\Rules\\RequireStringArgumentInConstructorRule" class\. Use unique content or abstract service instead#'

Hmm, I don't really think this is worth it to be honest.

Hmm, I don't really think this is worth it to be honest.

PHPStan is hard at first use, but very addictive in time :)

How would you refactor it?

Could you update the PR title to include the package?

The code itself looks very good 👍

Hmm, I don't really think this is worth it to be honest.

PHPStan is hard at first use, but very addictive in time :)

How would you refactor it?

I don't agree that moving this single function to a new service that we use in both this rule and RequireStringArgumentInMethodCallRule will make it better or easier to understand.

@ruudk I see. If you're able to put that in code, feel free to update the PHPStan rule

@TomasVotruba It's ready.

Applied feedback, ✅ green

This one is also ready for review ☺️

After this I will create a PR to enable it for Rector.

It probably needs to wait before Symplify is tagged again?

It seems 2 comments are not displaying: #2968 (comment)

Should I also update the docs or is this done automatically?

@ruudk doc auto re-generated weekly https://github.com/symplify/symplify/blob/893fee82ec571ae840f235ebac1ebcbff3e340ba/.github/workflows/weekly_pull_requests.yaml

@TomasVotruba Ready ✅

Thank you 👍