-
-
Notifications
You must be signed in to change notification settings - Fork 222
Convert travis to github actions #803
Conversation
.github/workflows/publish.yml
Outdated
strategy: | ||
matrix: | ||
os: [ubuntu-latest] | ||
node-version: [18.x] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node-version: [18.x] | |
node-version: [10.x, 20.x] |
Oldest supported + current covers both ends of supported version range
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that we should test on both ends of the range before publishing.
I have updated the action to test with both node 10 and node 18 and then finally build with node 18 and publish once both tests pass.
I think we should wait to use node 20 until we've added it to the test suite that runs on every PR.
I created a PR to add that here #804
I think that is inline with getting a version 1.5.0 published as you mentioned here: #800 (comment)
As the Node.js v14 is the latest so far maintained version, shouldn't both the |
Indeed! My above comment is asking for merging and releasing non-breaking maintenance- and security updates for a minor release prior to what you are describing. This would propagate those fixes to dependents on e.g. |
Okay, merged this, will create a new version later today, fingers crossed |
In process right now https://github.com/depcheck/depcheck/actions/runs/5928223128 |
Aand it failed 😭 |
Wooohooo!! Thanks everyone! https://www.npmjs.com/package/depcheck/v/1.4.5 I'll update the changelog. <3 |
@legobeat for sure! Now that the release pipeline is back up we can do everything :) once again, massive thanks to everyone for this |
Hey 👋🏻 ,
This PR adds a github action to publish depcheck to the npm registry.
This is a requested feature per #800 (comment)
To run this in your fork just add an npm access token to the "Actions secrets and variables" section in the project settings.
Example
To create a new release we just have to create a new semver compatible tag and publish.
https://github.com/a-rothwell/depcheck/releases/tag/123.456.789
Screen Shot of new release
This then kicks off a new action which builds, tests, and publishes the new version
Screen shot of action
Resulting NPM page https://www.npmjs.com/package/arothwell-ci-test-depcheck?activeTab=versions
Screen shot of NPM package published