Skip to content
This repository was archived by the owner on Jun 16, 2025. It is now read-only.

chore: downgrade sass to unbreak node 10 #798

Closed
wants to merge 2 commits into from
Closed

chore: downgrade sass to unbreak node 10 #798

wants to merge 2 commits into from

Conversation

legobeat
Copy link
Contributor

@legobeat legobeat commented May 14, 2023 •
edited
Loading

#710 upgraded version constraint of dependency sass to ^1.50.1. However, while depcheck still indicates support for nodejs 10, the latest version of sass with support for node 10 is 1.49.0.

This draws down the range so current main branch (and maintenance fixes) can be released straight from main to 1.x before doing a semver-major.

Also includes applies of npm audit --fix and npm dedupe on transient deps.

This was referenced May 15, 2023
Closed
Merged
@znarf
Copy link
Collaborator

znarf commented Jun 9, 2023

Node 10 was "end of life" on 2021-04-30. I don't think it should be supported.

@legobeat
Copy link
Contributor Author

legobeat commented Jul 18, 2023 •
edited
Loading

Node 10 was "end of life" on 2021-04-30. I don't think it should be supported.

That may be so, but dropping support is a breaking change, warranting a major version bump. And in either case, engines.node should be updated accordingly.

@legobeat legobeat force-pushed the chore-downgrade-sass branch from 1fbed4d to 0e47813 Compare July 18, 2023 00:26
@legobeat
Copy link
Contributor Author

legobeat commented Aug 8, 2023 •
edited
Loading

So the idea here would be to merge this fix, enabling a semver-minor-release (unless something else breaking came in in the meantime I missed) to get bugfixes and security fixes to dependents who aren't actively bump it, to then enable again upgrading sass and officially deprecate node 10 (and maybe even 12? maintainer call) right after that.

Nobody's arguing for maintaining support for Node v10 AFAIK!

@legobeat legobeat mentioned this pull request Aug 22, 2023
Merged
@legobeat legobeat force-pushed the chore-downgrade-sass branch from 0e47813 to 1da744a Compare August 22, 2023 07:12
@rumpl
Copy link
Member

rumpl commented Sep 11, 2023

We no longer depend on sass, let me close this one

@rumpl rumpl closed this Sep 11, 2023
@legobeat
Copy link
Contributor Author

@rumpl Right, but how about #801 ? This was primarily intended as unblocker for that. Just rebased in on top of current main after the most recent merges.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legobeat @znarf @rumpl