This repository was archived by the owner on Jun 16, 2025. It is now read-only.
fix: allow using @types-module for typescript type-only imports #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rexxars
added a commit
to sanity-io/sanity
that referenced
this pull request
Sep 6, 2021
This is only required to make depcheck pass - we're only importing the types, which are given by `@types/inquirer`, but depcheck doesn't understand this. I created a PR[1] against depcheck to fix this, but it is hard to know when/if this patch will land, so this seems like a reasonable workaround given it is only a development dependency. [1]: depcheck/depcheck#670
rexxars
added a commit
to sanity-io/sanity
that referenced
this pull request
Sep 6, 2021
This is only required to make depcheck pass - we're only importing the types, which are given by `@types/inquirer`, but depcheck doesn't understand this. I created a PR[1] against depcheck to fix this, but it is hard to know when/if this patch will land, so this seems like a reasonable workaround given it is only a development dependency. [1]: depcheck/depcheck#670
rexxars
added a commit
to sanity-io/sanity
that referenced
this pull request
Sep 6, 2021
This is only required to make depcheck pass - we're only importing the types, which are given by `@types/inquirer`, but depcheck doesn't understand this. I created a PR[1] against depcheck to fix this, but it is hard to know when/if this patch will land, so this seems like a reasonable workaround given it is only a development dependency. [1]: depcheck/depcheck#670
rexxars
added a commit
to sanity-io/sanity
that referenced
this pull request
Sep 6, 2021
This is only required to make depcheck pass - we're only importing the types, which are given by `@types/inquirer`, but depcheck doesn't understand this. I created a PR[1] against depcheck to fix this, but it is hard to know when/if this patch will land, so this seems like a reasonable workaround given it is only a development dependency. [1]: depcheck/depcheck#670
LinusU
approved these changes
Sep 6, 2021
ricokahler
pushed a commit
to sanity-io/sanity
that referenced
this pull request
Sep 7, 2021
This is only required to make depcheck pass - we're only importing the types, which are given by `@types/inquirer`, but depcheck doesn't understand this. I created a PR[1] against depcheck to fix this, but it is hard to know when/if this patch will land, so this seems like a reasonable workaround given it is only a development dependency. [1]: depcheck/depcheck#670
rexxars
added a commit
to sanity-io/sanity
that referenced
this pull request
Sep 7, 2021
This is only required to make depcheck pass - we're only importing the types, which are given by `@types/inquirer`, but depcheck doesn't understand this. I created a PR[1] against depcheck to fix this, but it is hard to know when/if this patch will land, so this seems like a reasonable workaround given it is only a development dependency. [1]: depcheck/depcheck#670
rexxars
added a commit
to sanity-io/sanity
that referenced
this pull request
Sep 7, 2021
This is only required to make depcheck pass - we're only importing the types, which are given by `@types/inquirer`, but depcheck doesn't understand this. I created a PR[1] against depcheck to fix this, but it is hard to know when/if this patch will land, so this seems like a reasonable workaround given it is only a development dependency. [1]: depcheck/depcheck#670
rexxars
added a commit
to sanity-io/sanity
that referenced
this pull request
Sep 7, 2021
This is only required to make depcheck pass - we're only importing the types, which are given by `@types/inquirer`, but depcheck doesn't understand this. I created a PR[1] against depcheck to fix this, but it is hard to know when/if this patch will land, so this seems like a reasonable workaround given it is only a development dependency. [1]: depcheck/depcheck#670
rumpl
approved these changes
Nov 9, 2021
|
@rexxars thanks for the PR, could you amend your commit and force push to kickstart the CI please, I have no idea why I can run the actions on your PR... |
3ae07d3 to
8643cd3
Compare
|
Sure. Rebased. |
Codecov Report
@@ Coverage Diff @@
## main #670 +/- ##
==========================================
- Coverage 98.64% 98.45% -0.18%
==========================================
Files 49 49
Lines 1023 1031 +8
==========================================
+ Hits 1009 1015 +6
- Misses 14 16 +2
Continue to review full report at Codecov.
|
|
Thanks @rexxars |
|
Thanks for merging! Any chance of seeing this one in a release anytime soon? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #568
Fixes #526
I'm not sure if this is the best approach, given none of the other detectors seems to be using the second
depsargument, but the alternative would be to change the returned value from an array of strings to an object that includes dependency names and an additional property for the type of import, or similar.