I'd also like to see node: supported. Thanks for working on it @karlhorky!

Also wanted to add a quick note that you may want to consider using is-core-module (which was split from resolve in browserify/resolve@7c26483) so that you don't have to maintain your own list of core modules.

node: prefix introduced in Node v16 (will be backported to v14 soon)

Also, a quick note that node: support was backported to v14.13.1 and v12.20.0.

@kevinoid Wow, really cool, thanks for the heads up!

I've commented about this also over at DefinitelyTyped on the PR to @types/node where they reverted the node: prefix feature:

DefinitelyTyped/DefinitelyTyped#52595 (comment)

Also wanted to add a quick note that you may want to consider using is-core-module (which was split from resolve in browserify/resolve@7c26483) so that you don't have to maintain your own list of core modules.

Yeah @rumpl, I agree here - if you would prefer that I switched it out for this other well-maintained module instead, happy to give that a shot.

Ah, maybe require / CommonJS support is not quite there yet for v14 and v12:

In Node 16 require('node:fs') works, but it looks like it still doesn't in 14.17.0.

DefinitelyTyped/DefinitelyTyped#52595 (comment)

Good catch @karlhorky, I had missed that!

Looks like require() support is being held for a bit before backporting: nodejs/node#37246 (comment)

Codecov Report

Merging #635 (fba121b) into main (843f46d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #635   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          48       48           
  Lines        1017     1017           
=======================================
  Hits         1003     1003           
  Misses         14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3da0d6f...fba121b. Read the comment docs.

Also wanted to add a quick note that you may want to consider using is-core-module (which was split from resolve in browserify/resolve@7c26483) so that you don't have to maintain your own list of core modules.

Yeah @rumpl, I agree here - if you would prefer that I switched it out for this other well-maintained module instead, happy to give that a shot.

@karlhorky that would be awesome, we used to use punycode but had to remove it, I'll be happy to merge a PR that would use is-core-module :)

@rumpl ok done in 91ec86f

Thanks! Could you squash your three commits and then we can merge?

Ok, squashed - as long as the tests pass, I think this is good to go!

Oops, forgot one of the imports, removed it.

Thanks!

Glad to help, thanks for the merge! Will this be published in a new minor version (1.5.0)?

It will yes, I'll push a new version later in the day (after I finish my real job 😅)

No rush, big thanks for all of your work on this project!

@rumpl any news on a new version?

I just pushed the 1.4.2 tag, it should be available on npm soon, sorry about that

Oh no... travis actually doesn't work any more 😭

🎉 https://www.npmjs.com/package/depcheck/v/1.4.2

Thanks! hehe meme game on point