Skip to content

Conversation

niik
Copy link
Member

@niik niik commented Oct 10, 2024

Description

Based on #19102 this aligns Desktop with GitHub.com's behavior of inserting the unicode character for emoji's selected via the autocomplete popover (initiated by typing :).

Screenshots

Before

Screenshot showing the literal string :+1: in the commit message dialog

After

Screenshot showing the unicode character for the thumbs up emoji in the commit message dialog

Release notes

Notes:

Base automatically changed from unicode-emoji to development October 10, 2024 11:06
@sergiou87
Copy link
Member

@niik is it possible you pushed the wrong changes here? 🤔 Either that or changing the base after #19102 has broken something 😳

@niik
Copy link
Member Author

niik commented Oct 14, 2024

@niik is it possible you pushed the wrong changes here? 🤔 Either that or changing the base after #19102 has broken something 😳

What on earth is going on here? I'm so confused. Let me get this sorted

@niik niik force-pushed the insert-unicode-emoji branch from 1a18248 to 3036127 Compare October 14, 2024 08:17
@niik niik requested a review from sergiou87 October 14, 2024 09:15
Co-Authored-By: Sergio Padrino <1083228+sergiou87@users.noreply.github.com>
@niik niik requested a review from sergiou87 October 14, 2024 14:31
@sergiou87
Copy link
Member

I love this!! 😍

@niik niik merged commit 9e8f058 into development Oct 15, 2024
7 checks passed
@niik niik deleted the insert-unicode-emoji branch October 15, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants