Use unicode emoji #19102
Merged
Use unicode emoji #19102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be9a30f to
6a9c7bf
Compare
niik
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Looks good! There's two things I'd like to address as part of this work but I'm happy if we do it in a separate PR.
First I'd like for us to not include the image assets in the final bundle for the emoji that have unicode representation. Secondly I'd like for us to align with dotcom's behavior of inserting the unicode character when typing :+1... in a text editor instead of inserting the literal :+1: string. I can take a stab at the latter.
Merged
|
Love it! I will merge this now and take care of the assets later. Loving your PR already 😍 |
|
@sergiou87 Hey, Where to get this emoji "memes" pack? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #19101
Description
This PR prefers the use of unicode emoji characters over image-based emojis.
Screenshots
Windows
macOS
Release notes
Notes: [Improved] Use OS emojis