-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Closed
Closed
Copy link
Labels
bugConfirmed bugs or reports that are very likely to be bugsConfirmed bugs or reports that are very likely to be bugspriority-2Bug that affects more than a few users in a meaningful way but doesn't prevent core functionsBug that affects more than a few users in a meaningful way but doesn't prevent core functions
Description
The problem
The app repeatedly prompts me for my SSH key passphrase throughout the day, triggered by a background fetch. If I enter my passphrase and check the "Remember passphrase" box, at some point I will be prompted again on a future background fetch. However, the prompt is clearly not required; if I trigger an action manually, I'm not prompted and the action succeeds. I only have two repos added to GitHub Desktop, and I can confirm both work for manual actions without prompting for a passphrase. Something somewhere is remembering the passphrase, but sometimes it doesn't work for background fetch.
Release version
3.4.2
Operating system
macOS Sonoma 14.5
Steps to reproduce the behavior
- Have an SSH key with a passphrase, with that passphrase added to ssh-agent or whatever
- may be relevant: I'm also using the following settings in my ~/.ssh/config:
Host *
UseKeychain yes
ControlMaster auto
ControlPath /tmp/%r@%h:%p
ControlPersist yes
- Clone a repo or two via SSH with that key from the command line
- Add that/those repo(s) to GitHub Desktop
- Wait for a background fetch
Log files
2024-07-26.desktop.production.log
This was the first thing I did this morning:
- look at GitHub Desktop which had been open overnight
- saw the passphrase prompt
- entered my passphrase & checked "Remember passphrase"
The fetch seemed to complete without errors after that, or at least the UI didn't surface any errors to me.
Screenshots
No response
Additional context
No response
Metadata
Metadata
Assignees
Labels
bugConfirmed bugs or reports that are very likely to be bugsConfirmed bugs or reports that are very likely to be bugspriority-2Bug that affects more than a few users in a meaningful way but doesn't prevent core functionsBug that affects more than a few users in a meaningful way but doesn't prevent core functions