Improve SSH credential support #19042
Merged
+212
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means saving them in the keychain when they're introduced and deleting them if the git operation failed due to an auth error.
sergiou87
commented
Jul 31, 2024
| @@ -124,50 +124,52 @@ export async function withTrampolineEnv<T>( | |||
| // `fn` has been invoked, we can store the SSH key passphrase for this git | |||
| // operation if there was one pending to be stored. | |||
| try { | |||
| const result = await fn({ | |||
| return await fn({ | |||
There was a problem hiding this comment.
We need to await here to make sure errors are caught by try…catch…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19019
Description
This PR makes a few changes to improve SSH credential support from Desktop to make its logic more similar to the one we have for generic HTTPS credentials:
Release notes
Notes: [Fixed] Only ask for SSH credentials for the selected repository and only delete them after an authentication error