Skip to content

refactor: change left/right diff text to actual/expected #4697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2020
Merged

refactor: change left/right diff text to actual/expected #4697

merged 1 commit into from
Apr 10, 2020

Conversation

cknight
Copy link
Contributor

@cknight cknight commented Apr 10, 2020

Given that the API for testing asserts is defined as such:

export function assertEquals(actual: unknown, expected: unknown, msg?: string): void

Then the output should report Actual vs Expected rather than Left vs Right:

Screenshot at 2020-04-10 14:42:05

ry
ry approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ry ry merged commit 85c61bf into denoland:master Apr 10, 2020
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 21, 2021
@cknight
fix(std/testing/asserts): change left/right to actual/expected (denol…
46fb548 
…and/deno#4697)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@cknight
fix(testing/asserts): change left/right to actual/expected (denoland/…
4722884 
…deno#4697)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@cknight @caspervonb
fix(testing/asserts): change left/right to actual/expected (denoland/…
32b340a 
…deno#4697)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 24, 2021
@cknight @caspervonb
fix(testing/asserts): change left/right to actual/expected (denoland/…
24fa7bb 
…deno#4697)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@cknight @caspervonb
fix(testing/asserts): change left/right to actual/expected (denoland/…
8ee324d 
…deno#4697)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@cknight @caspervonb
fix(testing/asserts): change left/right to actual/expected (denoland/…
21eae4f 
…deno#4697)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@cknight @caspervonb
fix(testing/asserts): change left/right to actual/expected (denoland/…
d339a6c 
…deno#4697)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Jan 31, 2021
@cknight @denobot
fix(testing/asserts): change left/right to actual/expected (denoland/…
905e4ad 
…deno#4697)
caspervonb pushed a commit to caspervonb/deno_std that referenced this pull request Feb 1, 2021
@cknight @denobot
fix(testing/asserts): change left/right to actual/expected (denoland/…
3660561 
…deno#4697)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cknight @ry