Log improvements and new log handler #4674
Conversation
std/log/handlers.ts
Outdated
| /** @deprecated - `this._writer.write()` is an async call. Under heavy load | ||
| * testing has shown a significant loss of log messages being written. Also, | ||
| * if the process terminates while writing a log, that log message is also | ||
| * lost. It is recommended that handlers override this method with a | ||
| * synchronous implementation (see FileHandler). | ||
| */ |
There was a problem hiding this comment.
Just remove this method completely, no need to mark it as deprecated
There was a problem hiding this comment.
As the WriteHandler class is abstract, I've removed the @deprecated comment and changed this log method to be abstract too. This will generate compile errors for anyone currently subclassing WriterHandler with a custom implementation rather than if I removed it entirely, which would cause log() fall back to BaseHandler with a noop log method which could confuse or cause issues.
| this._writer = this._file; | ||
| } | ||
|
|
||
| log(msg: string): void { |
There was a problem hiding this comment.
Just an idea - support both log and logSync methods?
There was a problem hiding this comment.
Yes, I considered this too. This definitely needs more thought though as I think the async implementation isn't straightforward, at least to get something robust which can handle high throughput. Something for another PR I think.
| Error, | ||
| "maxBackupCount cannot be less than 1" | ||
| ); | ||
| }, |
|
Thanks for the review @bartlomieju. That's my review changes now uploaded. |
This PR brings a number of improvements to the std logger:
cc @bartlomieju