Use explicit memory ownership in SocketMultiplexer #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sithlord48
pushed a commit
to deskflow/deskflow
that referenced
this pull request
May 25, 2025
ported-by: sithlord48
sithlord48
pushed a commit
to deskflow/deskflow
that referenced
this pull request
Jun 12, 2025
ported-by: sithlord48
sithlord48
pushed a commit
to deskflow/deskflow
that referenced
this pull request
Jun 14, 2025
ported-by: sithlord48
sithlord48
pushed a commit
to deskflow/deskflow
that referenced
this pull request
Jun 14, 2025
ported-by: sithlord48
sithlord48
pushed a commit
to deskflow/deskflow
that referenced
this pull request
Jun 14, 2025
ported-by: sithlord48
sithlord48
pushed a commit
to deskflow/deskflow
that referenced
this pull request
Jun 15, 2025
ported-by: sithlord48
sithlord48
pushed a commit
to deskflow/deskflow
that referenced
this pull request
Jun 17, 2025
ported-by: sithlord48
sithlord48
pushed a commit
to deskflow/deskflow
that referenced
this pull request
Jun 19, 2025
ported-by: sithlord48
sithlord48
pushed a commit
to deskflow/deskflow
that referenced
this pull request
Jun 19, 2025
ported-by: sithlord48
sithlord48
pushed a commit
to deskflow/deskflow
that referenced
this pull request
Jun 20, 2025
ported-by: sithlord48
sithlord48
pushed a commit
to deskflow/deskflow
that referenced
this pull request
Jun 23, 2025
ported-by: sithlord48
sithlord48
pushed a commit
to deskflow/deskflow
that referenced
this pull request
Jun 30, 2025
ported-by: sithlord48
sithlord48
pushed a commit
to deskflow/deskflow
that referenced
this pull request
Jul 14, 2025
ported-by: sithlord48
sithlord48
pushed a commit
to deskflow/deskflow
that referenced
this pull request
Jul 14, 2025
ported-by: sithlord48
sithlord48
pushed a commit
to deskflow/deskflow
that referenced
this pull request
Jul 25, 2025
ported-by: sithlord48
sithlord48
pushed a commit
to deskflow/deskflow
that referenced
this pull request
Jul 29, 2025
ported-by: sithlord48
sithlord48
pushed a commit
to deskflow/deskflow
that referenced
this pull request
Aug 6, 2025
ported-by: sithlord48
sithlord48
pushed a commit
to deskflow/deskflow
that referenced
this pull request
Aug 11, 2025
ported-by: sithlord48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code of SocketMultiplexer is extremely hard to follow, as the ownership of various data is not clear. This PR fixes that by making ownership explicit by using
std::unique_ptr. While no memory leaks have been detected or fixed, this will make this basically impossible in the future.