core: Don't use wallet for swap fee estimate. #3200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swap fees are dictated by the server so the local wallets suggestion does not need to be considered when estimating fees in SingleLotFees. This changes leaves the code matching its comment, and also matching how fees are calculated/estimated in other places (e.g. PreOrder)
JoeGruffins
approved these changes
Feb 25, 2025
martonp
approved these changes
Feb 25, 2025
buck54321
pushed a commit
that referenced
this pull request
Feb 25, 2025
Swap fees are dictated by the server so the local wallets suggestion does not need to be considered when estimating fees in SingleLotFees. This changes leaves the code matching its comment, and also matching how fees are calculated/estimated in other places (e.g. PreOrder)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap fees are dictated by the server so the local wallets suggestion does not need to be considered when estimating fees in SingleLotFees.
This changes leaves the code matching its comment, and also matching how fees are calculated/estimated in other places (e.g. PreOrder)