Skip to content

client: Allow Firo to send to an EXX address. #3119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 27, 2025
Merged

client: Allow Firo to send to an EXX address. #3119

merged 6 commits into from
Feb 27, 2025

Conversation

dev-warrior777
Copy link
Contributor

@dev-warrior777 dev-warrior777 commented Dec 11, 2024 •
edited
Loading 

- EXX addresses are used for Firo and other privacy coins to
  send funds to  Binance and other exchanges due to last US
  administration regulations.
  • This PR makes a non-standard P2PKH script to enable this.

@dev-warrior777
Copy link
Contributor Author

dev-warrior777 commented Dec 11, 2024 •
edited
Loading

Dex Electrum Firo => Binance

image

@dev-warrior777
Copy link
Contributor Author

Working using Dex Electrum Firo wallet. And can send to Binance and to Firo full node.

  • Todo: Test on Dex Firo full-node.

@dev-warrior777
Copy link
Contributor Author

dev-warrior777 commented Dec 12, 2024 •
edited
Loading

Dex full-node => Binance Tx

2024-12-12 14:53:07.987 [DBG] CORE[firo]: 2 signature cycles to converge on fees for tx 48447697517d82f177143962b8c98904208bd09c8ff743bd4672198c5ed1a824: min rate = 1, actual fee rate = 1 (226 for 226 bytes), change = true
2024-12-12 14:53:08.000 [INF] CORE: notify: |SUCCESS| (send) Send successful - Sending 0.33300000 firo to EXXKcAcVWXeG7S9aiXXGuGNZkWdB9XuSbJ1z has completed successfully. Tx ID = 48447697517d82f177143962b8c98904208bd09c8ff743bd4672198c5ed1a824:0

image

@dev-warrior777 dev-warrior777 marked this pull request as ready for review December 12, 2024 15:03
buck54321
buck54321 reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@buck54321 buck54321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at an older commit of yours when I started this, but check out this variation please.

buck54321/dcrdex@0030e49...buck54321:dcrdex:exx-addr-interface

@dev-warrior777
Copy link
Contributor Author

I was looking at an older commit of yours when I started this, but check out this variation please.

buck54321/dcrdex@0030e49...buck54321:dcrdex:exx-addr-interface

Thanks for this. The logic did not change between c6db64d and 7a86357, just additional tests & cleanup, so your suggestion is welcome.

Please believe me when I say I considered making an interface to identify the user of the PayToAddrScript(addr) before I went the other route. My concern was always to minimize any footprint in common code and your code does this better. It is also less C-like than mine and solves the issue of the address encoding information being "lost" in btcutil.Address . More elegant.

Let me take a look today and send some more Firo to Binance. I also want to keep a couple of other currently unused byte constants for normal transparent addresses around for future use.

JoeGruffins
JoeGruffins reviewed Feb 21, 2025
View reviewed changes
Copy link
Member

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested but looks correct to me.

dev-warrior777 added 6 commits February 26, 2025 11:37
client: Allow Firo to send to an EXX address. decred#4
7dd9cee 
	EXX addresses are used for Firo and other privacy coins to
	send funds to  Binance and other exchanges due to last US
	administration regulations.
imports: update go.mod for btcsuite/btcd/btcutil/base58 decred#5
a9ff529
client: Add tests and tidy.
7f52939 
	- Add testnet tests
	- Add more Documentation
client/asset: re-implement using btc.PaymentScripter interface.
f9181cc
firo: Update Exx address related tests.
f996e5e 
	- Also changed electrumx.sh to expose both
	  TCP and SSL listening services on ports
	  50001 and 50002 respectively.
mm,libxc: Remove Firo from assetDisabled list.
23fa5cb
@buck54321 buck54321 merged commit a86797e into decred:master Feb 27, 2025
5 checks passed
buck54321 pushed a commit that referenced this pull request Feb 27, 2025
@dev-warrior777 @buck54321
client: Allow Firo to send to an EXX address. (#3119)
e65d4ad 
* client: Allow Firo to send to an EXX address.  #4

	EXX addresses are used for Firo and other privacy coins to
	send funds to  Binance and other exchanges due to last US
	administration regulations.

* imports: update go.mod for btcsuite/btcd/btcutil/base58  #5

* client: Add tests and tidy.

	- Add testnet tests
	- Add more Documentation

* client/asset: re-implement using btc.PaymentScripter interface.

* firo: Update Exx address related tests.

	- Also changed electrumx.sh to expose both
	  TCP and SSL listening services on ports
	  50001 and 50002 respectively.

* mm,libxc: Remove Firo from assetDisabled list.

---------

Co-authored-by: dev-warrior777 <>
@dev-warrior777 dev-warrior777 deleted the sendexx branch March 5, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buck54321 buck54321 buck54321 left review comments

@JoeGruffins JoeGruffins JoeGruffins approved these changes

+1 more reviewer

@martonp martonp martonp approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dev-warrior777 @buck54321 @martonp @JoeGruffins