Skip to content

mm: Fix deposit balance check deadlock #3066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

martonp
Copy link
Collaborator

@martonp martonp commented Nov 9, 2024

Fixes a possible deadlock due to a nested RLock.

Closes #3062

Fixes a possible deadlock due to a nested RLock.
Copy link
Member

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hadn't expected this, but I guess the lock can queue between the read locks?

https://go.dev/play/p/9m3ll9ZE2d8

@buck54321 buck54321 merged commit b7a3c33 into decred:master Nov 11, 2024
5 checks passed
buck54321 pushed a commit to buck54321/dcrdex that referenced this pull request Nov 12, 2024
Fixes a possible deadlock due to a nested RLock.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testing/mm: Test timeout while running TestDeposit/not_withdrawer,_dynamic_swapper.
3 participants