-
Notifications
You must be signed in to change notification settings - Fork 126
spec: change limit-limit rate. two minconfs. clarifications and cleanup #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
approved these changes
Jul 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
dnldd
added a commit
to dnldd/dcrdex
that referenced
this pull request
Dec 11, 2019
dnldd
added a commit
to dnldd/dcrdex
that referenced
this pull request
Feb 5, 2020
dev-warrior777
pushed a commit
to dev-warrior777/dcrdex
that referenced
this pull request
Jan 30, 2025
dev-warrior777
pushed a commit
to dev-warrior777/dcrdex
that referenced
this pull request
Jan 31, 2025
…ecred#2. - This is a rework of decred#3096 and keeps the Build ID in the settings dialog. - Webpack Build ID for caching site/dist build will be addressed in another PR if required.
dev-warrior777
pushed a commit
to dev-warrior777/dcrdex
that referenced
this pull request
Jan 31, 2025
dev-warrior777
pushed a commit
to dev-warrior777/dcrdex
that referenced
this pull request
Feb 2, 2025
dev-warrior777
pushed a commit
to dev-warrior777/dcrdex
that referenced
this pull request
Feb 2, 2025
- uploads to browser - upload preparation logic errors cause the browser to show bad page load - does not work on webview
JoeGruffins
pushed a commit
that referenced
this pull request
Feb 3, 2025
…#3121) * client: Use the app build version as Version in UI in hamburger menu #2. - This is a rework of #3096 and keeps the Build ID in the settings dialog. - Webpack Build ID for caching site/dist build will be addressed in another PR if required. * client: Re-work profile dropdown to show simplified, user-facing app version * client,webserver: re-work to modify config per JoeGruff suggestions #2 * client,app,webserver: Remove un-needed configuration variables. --------- Co-authored-by: dev-warrior777 <>
martonp
pushed a commit
to martonp/dcrdex
that referenced
this pull request
Jul 8, 2025
…decred#3121) * client: Use the app build version as Version in UI in hamburger menu decred#2. - This is a rework of decred#3096 and keeps the Build ID in the settings dialog. - Webpack Build ID for caching site/dist build will be addressed in another PR if required. * client: Re-work profile dropdown to show simplified, user-facing app version * client,webserver: re-work to modify config per JoeGruff suggestions decred#2 * client,app,webserver: Remove un-needed configuration variables. --------- Co-authored-by: dev-warrior777 <>
buck54321
pushed a commit
that referenced
this pull request
Jul 26, 2025
…#3121) * client: Use the app build version as Version in UI in hamburger menu #2. - This is a rework of #3096 and keeps the Build ID in the settings dialog. - Webpack Build ID for caching site/dist build will be addressed in another PR if required. * client: Re-work profile dropdown to show simplified, user-facing app version * client,webserver: re-work to modify config per JoeGruff suggestions #2 * client,app,webserver: Remove un-needed configuration variables. --------- Co-authored-by: dev-warrior777 <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General tweaks based on feedback from various channels.