Updated GoDaddy to new IPv4/IPv6 logic. #446 #560
Conversation
…trategie for old "use" was detected. Now old "use" can be set to "disabled" as well, to prevent a third lookup if "usev4" and "usev6" was enabled.
|
Thanks for the contribution! We will leave this pull request open until v3.11.0 has been released (see #552 (comment) for details). It will get pulled into v3.11.1 |
|
v3.11.0 has been released, please rebase your branch on top of master (and remove the three merge commits). Additionally, your change to the 'use' logic is not needed as far as i can tell: |
|
Reminder: For this to get merged, please first:
|
Changes by Lenard Hess based on Awalon's pull request: - Rebased to master - Removed use=disabled addition from this commit
|
The changes are done and committed in commit f5a1a90. |
Hello new maintainer, as my previous pr #446 was just closed here another try:
Updated my previously provided GoDaddy integration (#398) to support IPv6 as well (sub nic_godaddy_update; via new wantipv4 + wantipv6 values and loop for them), github diff shows more changes as made (indentation caused by new loop).
In addition:
During testing a gap in ip_strategie for old "use" was detected. Now old "use" can be set to "disabled" as well, to prevent a third lookup if "usev4" and "usev6" was enabled until the old "no" was set. The new "disabled" which was already supported by code seems to be more user friendly.