Use OAuth2 prompt to force login/account selection by provider
#1270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/oauth-prompts
|
| Run status |
|
| Run duration | 08m 55s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
504
|
| View all changes introduced in this branch ↗︎ | |
8b6dfce to
5e3cf58
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1270 +/- ##
==========================================
+ Coverage 74.36% 74.42% +0.06%
==========================================
Files 66 66
Lines 4497 4520 +23
==========================================
+ Hits 3344 3364 +20
- Misses 1153 1156 +3
🚀 New features to boost your workflow:
|
be-smith
pushed a commit
that referenced
this pull request
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1269.
This PR forces user's to login or select a logged in account whenever they hit the datalab login button. This is a requirement for using datalab on multi-user machines, as otherwise when one user logs out, the login button will automatically use the stored information according to the oauth provider.
Unfortunately, I had to vendor the flask-dance blueprints in order to expose the setting I needed, but these very rarely change (and indeed one of them was contributed upstream by me anyway).