Fix for either over- or under-specific file permissions #1279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1279 +/- ##
==========================================
+ Coverage 74.50% 74.57% +0.06%
==========================================
Files 66 66
Lines 4535 4535
==========================================
+ Hits 3379 3382 +3
+ Misses 1156 1153 -3
🚀 New features to boost your workflow:
|
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/fix-file-permissions
|
| Run status |
|
| Run duration | 08m 20s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
504
|
| View all changes introduced in this branch ↗︎ | |
be-smith
pushed a commit
that referenced
this pull request
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported a few times by @jdbocarsly and @PeterKraus, file permissions are currently too all-or-nothing; either all users who know the file ID should be able to access it (typically only possible if they have access to the item that the file is attached to), or they have to have full access to the file as an uploader. The former approach is problematic, as a user may lose permissions but still be able to access the file.
This PR alters that by tying file permissions to the item permissions more directly. This is a semi-temporary fix until full granular object permissions are implemented, but I imagine this will be the default after that refactor anyway.