Skip to content

Add creators in SampleTable global search #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

Add creators in SampleTable global search #1257

merged 1 commit into from
Jul 8, 2025

Conversation

BenjaminCharmes
Copy link
Contributor

Closes #1256

@codecov Codecov
Copy link

codecov bot commented Jun 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.28%. Comparing base (4bc78e1) to head (1d1a13f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1257   +/-   ##
=======================================
  Coverage   74.28%   74.28%           
=======================================
  Files          66       66           
  Lines        4487     4487           
=======================================
  Hits         3333     3333           
  Misses       1154     1154
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress Cypress
Copy link

cypress bot commented Jun 27, 2025

datalab    Run #3539

Run Properties:  status check passed Passed #3539  •  git commit 122c8310ec ℹ️: Merge 7f39339cb93429563c9603bab72d862d7ba641d8 into d7f5b8027f62b048bb5e22328acf...
Project datalab
Branch Review bc/search-creators
Run status status check passed Passed #3539
Run duration 08m 25s
Commit git commit 122c8310ec ℹ️: Merge 7f39339cb93429563c9603bab72d862d7ba641d8 into d7f5b8027f62b048bb5e22328acf...
Committer Ben Charmes
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 504
View all changes introduced in this branch ↗︎

@ml-evs ml-evs requested a review from be-smith June 30, 2025 09:27
be-smith
be-smith approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@be-smith be-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ml-evs ml-evs force-pushed the bc/search-creators branch from 7f39339 to 1d1a13f Compare July 8, 2025 17:45
@ml-evs ml-evs enabled auto-merge (squash) July 8, 2025 17:45
@ml-evs ml-evs merged commit 6dd40ce into main Jul 8, 2025
18 checks passed
@ml-evs ml-evs deleted the bc/search-creators branch July 8, 2025 17:57
be-smith pushed a commit that referenced this pull request Jul 30, 2025
@BenjaminCharmes @be-smith
Add creators in SampleTable global search (#1257)
bf78d91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ml-evs ml-evs ml-evs approved these changes

@be-smith be-smith be-smith approved these changes

@jdbocarsly jdbocarsly Awaiting requested review from jdbocarsly jdbocarsly is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creators are not search in global table search
3 participants
@BenjaminCharmes @ml-evs @be-smith