Skip to content

Add tests for hazard statement -> H-code -> pictogram mappings #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 6, 2025
Merged

Add tests for hazard statement -> H-code -> pictogram mappings #1100

merged 3 commits into from
Apr 6, 2025

Conversation

ml-evs
Copy link
Member

@ml-evs ml-evs commented Apr 5, 2025

Closes #1086

@ml-evs ml-evs force-pushed the ml-evs/pictogram-tests branch from 0abbca7 to 690575c Compare April 5, 2025 12:04
@codecov Codecov
Copy link

codecov bot commented Apr 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.28%. Comparing base (9d17488) to head (6137ad8).
Report is 117 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1100   +/-   ##
=======================================
  Coverage   70.28%   70.28%           
=======================================
  Files          63       63           
  Lines        4129     4129           
=======================================
  Hits         2902     2902           
  Misses       1227     1227
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress Cypress
Copy link

cypress bot commented Apr 5, 2025 •
edited
Loading

datalab    Run #3053

Run Properties:  status check passed Passed #3053  •  git commit a0ddb4ce1f ℹ️: Merge 6137ad8118fce1152783a92d2ce5f36a8ff3692a into 9d17488b04d11814244648cb8e81...
Project datalab
Branch Review ml-evs/pictogram-tests
Run status status check passed Passed #3053
Run duration 07m 09s
Commit git commit a0ddb4ce1f ℹ️: Merge 6137ad8118fce1152783a92d2ce5f36a8ff3692a into 9d17488b04d11814244648cb8e81...
Committer Matthew Evans
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 477
View all changes introduced in this branch ↗︎

@ml-evs ml-evs force-pushed the ml-evs/pictogram-tests branch 2 times, most recently from d836f0e to d12d70e Compare April 6, 2025 16:51
@ml-evs ml-evs force-pushed the ml-evs/pictogram-tests branch from d12d70e to b955d73 Compare April 6, 2025 16:56
@ml-evs ml-evs merged commit d82987b into main Apr 6, 2025
17 checks passed
@ml-evs ml-evs deleted the ml-evs/pictogram-tests branch April 6, 2025 18:41
BenjaminCharmes pushed a commit that referenced this pull request Apr 16, 2025
@ml-evs @BenjaminCharmes
Add tests for hazard statement -> H-code -> pictogram mappings (#1100)
5fdb3bd 
* Add hazard code to pictogram response

* Add test for H-code to pictogram mapping and separate h-code function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdbocarsly jdbocarsly Awaiting requested review from jdbocarsly jdbocarsly is a code owner

@BenjaminCharmes BenjaminCharmes Awaiting requested review from BenjaminCharmes BenjaminCharmes is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add explicit test for GHS pictogram generation and validation of strings
1 participant
@ml-evs