Skip to content

Make media block resizable #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 4, 2025
Merged

Make media block resizable #1099

merged 2 commits into from
Apr 4, 2025

Conversation

jdbocarsly
Copy link
Member

Closes #1093

@codecov Codecov
Copy link

codecov bot commented Apr 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.18%. Comparing base (511eb21) to head (f45fe24).
Report is 121 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1099   +/-   ##
=======================================
  Coverage   70.18%   70.18%           
=======================================
  Files          63       63           
  Lines        4119     4119           
=======================================
  Hits         2891     2891           
  Misses       1228     1228
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cypress Cypress
Copy link

cypress bot commented Apr 4, 2025

datalab    Run #3036

Run Properties:  status check passed Passed #3036  •  git commit 79e4a8b86c ℹ️: Merge 0b38ac6d727a6d0b8cbb314d88e9788791c7a82f into 511eb211630da44403cf7e43e5a9...
Project datalab
Branch Review jdb/resize_media
Run status status check passed Passed #3036
Run duration 06m 46s
Commit git commit 79e4a8b86c ℹ️: Merge 0b38ac6d727a6d0b8cbb314d88e9788791c7a82f into 511eb211630da44403cf7e43e5a9...
Committer Josh Bocarsly
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 471
View all changes introduced in this branch ↗︎

@ml-evs ml-evs force-pushed the jdb/resize_media branch from 0b38ac6 to f45fe24 Compare April 4, 2025 23:13
@ml-evs ml-evs marked this pull request as ready for review April 4, 2025 23:13
ml-evs
ml-evs approved these changes Apr 4, 2025
View reviewed changes
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resize is a bit janky but still as massive improvement, thanks!

@ml-evs ml-evs added webapp For issues/PRs pertaining to the web interface visuals For issues/PRs pertaining to visuals/aesthetics of the interface usability datablock An issue pertaining to a specific datablock labels Apr 4, 2025
@ml-evs ml-evs changed the title Make image block more sensible size (and/or resizable) Make media block resizable Apr 4, 2025
@ml-evs ml-evs enabled auto-merge (squash) April 4, 2025 23:15
@ml-evs ml-evs disabled auto-merge April 4, 2025 23:15
@ml-evs ml-evs enabled auto-merge (squash) April 4, 2025 23:15
@ml-evs ml-evs merged commit 603b387 into main Apr 4, 2025
17 checks passed
@ml-evs ml-evs deleted the jdb/resize_media branch April 4, 2025 23:25
BenjaminCharmes pushed a commit that referenced this pull request Apr 16, 2025
@jdbocarsly @BenjaminCharmes
Make media block resizable (#1099)
951b6f7 
* fix typo in MediaBlock so that images have a sensible max-height

* make image size draggable by the user (will not persist)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ml-evs ml-evs ml-evs approved these changes

@BenjaminCharmes BenjaminCharmes Awaiting requested review from BenjaminCharmes BenjaminCharmes is a code owner

Assignees
No one assigned
Labels
datablock An issue pertaining to a specific datablock usability visuals For issues/PRs pertaining to visuals/aesthetics of the interface webapp For issues/PRs pertaining to the web interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Media block resize
2 participants
@jdbocarsly @ml-evs