-
Notifications
You must be signed in to change notification settings - Fork 22
Add regex-based alternative to full-text search #1098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1098 +/- ##
==========================================
+ Coverage 70.18% 70.25% +0.07%
==========================================
Files 63 63
Lines 4119 4129 +10
==========================================
+ Hits 2891 2901 +10
Misses 1228 1228
🚀 New features to boost your workflow:
|
datalab
|
Project |
datalab
|
Branch Review |
ml-evs/regex-search
|
Run status |
|
Run duration | 07m 15s |
Commit |
|
Committer | Matthew Evans |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
471
|
View all changes introduced in this branch ↗︎ |
fc1e5d4
to
5bfa32d
Compare
9139811
to
09d5f1a
Compare
Going to merge this as a bit of a hidden feature, want to test it out on some real deployments before making it the default |
Add very simple regexp search test
09d5f1a
to
6747b51
Compare
BenjaminCharmes
pushed a commit
that referenced
this pull request
Apr 16, 2025
* Add regex-based search triggered with '%' at start of query Add very simple regexp search test * Tweak test case and handle quotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After noodling around in #993, I think the conclusion is that its not worth maintaining a potentially large separate custom index for FTS that works with only a few characters. Instead, as a bit of a prototype, this PR adds a simple regex-based search that can triggered in the item select by prefixing the query with "%". This seems to work fairly well at our typical database sizes, but might need some optimisations. For now it also only uses the fields that are currently part of the free-text index, but this could be expanded (and we can add real indices over these fields if performance is bad).
Closes #679?