Skip to content

Wrap block descriptions into block menu #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025
Merged

Wrap block descriptions into block menu #1096

merged 2 commits into from
Apr 4, 2025

Conversation

BenjaminCharmes
Copy link
Contributor

Closes #1085

Should be enough to handle docstrings

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.18%. Comparing base (673a7fb) to head (a976fd5).
Report is 123 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1096   +/-   ##
=======================================
  Coverage   70.18%   70.18%           
=======================================
  Files          63       63           
  Lines        4119     4119           
=======================================
  Hits         2891     2891           
  Misses       1228     1228           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

cypress bot commented Apr 4, 2025

datalab    Run #3029

Run Properties:  status check passed Passed #3029  •  git commit 09f5dc30f3 ℹ️: Merge a976fd59bcf78a41e66c1189e3f925c7e4502485 into 673a7fb50e2659db3dbb3706e343...
Project datalab
Branch Review bc/block-description
Run status status check passed Passed #3029
Run duration 07m 10s
Commit git commit 09f5dc30f3 ℹ️: Merge a976fd59bcf78a41e66c1189e3f925c7e4502485 into 673a7fb50e2659db3dbb3706e343...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 471
View all changes introduced in this branch ↗︎

@ml-evs ml-evs force-pushed the bc/block-description branch from 9d2a807 to a976fd5 Compare April 4, 2025 16:34
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ml-evs ml-evs merged commit 581a9d2 into main Apr 4, 2025
17 checks passed
@ml-evs ml-evs deleted the bc/block-description branch April 4, 2025 18:15
@ml-evs ml-evs added visuals For issues/PRs pertaining to visuals/aesthetics of the interface usability labels Apr 4, 2025
BenjaminCharmes added a commit that referenced this pull request Apr 16, 2025
* Add pre-wrap to StyledBlockHelp

* Add a max tooltip width of 40rem

---------

Co-authored-by: Matthew Evans <git@ml-evs.science>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability visuals For issues/PRs pertaining to visuals/aesthetics of the interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover block descriptions into block menu do not wrap and stretch to full screen
2 participants