Skip to content

Dynamic page titles #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Dynamic page titles #1051

merged 1 commit into from
Apr 10, 2025

Conversation

BenjaminCharmes
Copy link
Contributor

Closes #923

This PR add dynamic page titles in the router configuration.

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.28%. Comparing base (0e592da) to head (840d68e).
Report is 113 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1051   +/-   ##
=======================================
  Coverage   70.28%   70.28%           
=======================================
  Files          63       63           
  Lines        4129     4129           
=======================================
  Hits         2902     2902           
  Misses       1227     1227           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BenjaminCharmes BenjaminCharmes added webapp For issues/PRs pertaining to the web interface usability labels Feb 21, 2025
Copy link

cypress bot commented Feb 21, 2025

datalab    Run #2922

Run Properties:  status check passed Passed #2922  •  git commit 46ec57be7c ℹ️: Merge 5259b9f37399b654516ba9add8ce0fe47f3d037f into 17ab3575328038e4dc200814c5a3...
Project datalab
Branch Review bc/dynamic-site-title
Run status status check passed Passed #2922
Run duration 07m 11s
Commit git commit 46ec57be7c ℹ️: Merge 5259b9f37399b654516ba9add8ce0fe47f3d037f into 17ab3575328038e4dc200814c5a3...
Committer Ben Charmes
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 471
View all changes introduced in this branch ↗︎

@ml-evs ml-evs force-pushed the bc/dynamic-site-title branch from b889973 to 92f1933 Compare April 10, 2025 12:55
@ml-evs ml-evs force-pushed the bc/dynamic-site-title branch from 92f1933 to 840d68e Compare April 10, 2025 12:55
@ml-evs ml-evs marked this pull request as ready for review April 10, 2025 12:55
@ml-evs ml-evs requested a review from jdbocarsly as a code owner April 10, 2025 12:55
Copy link
Member

@ml-evs ml-evs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a minor typo, otherwise looks good!

@ml-evs ml-evs enabled auto-merge (squash) April 10, 2025 12:56
@ml-evs ml-evs merged commit cb4c7cf into main Apr 10, 2025
17 checks passed
@ml-evs ml-evs deleted the bc/dynamic-site-title branch April 10, 2025 13:07
BenjaminCharmes added a commit that referenced this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usability webapp For issues/PRs pertaining to the web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Site titles should reflect current page
2 participants