Skip to content

adding dapr-http-max-request-size parameter to cli #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 14, 2021
Merged

adding dapr-http-max-request-size parameter to cli #703

merged 4 commits into from
May 14, 2021

Conversation

apuzyrevsky
Copy link
Contributor

@apuzyrevsky apuzyrevsky commented Apr 29, 2021 •
edited
Loading

Description

adding dapr-http-max-request-size parameter to cli

Issue reference

#699

Please reference the issue this PR will close: #699

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@mukundansundar mukundansundar requested a review from artursouza May 5, 2021 16:08
@codecov
Copy link

codecov bot commented May 5, 2021 •
edited
Loading

Codecov Report

Merging #703 (52b87a2) into master (717eed9) will increase coverage by 0.11%.
The diff coverage is 25.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #703      +/-   ##
==========================================
+ Coverage   19.76%   19.88%   +0.11%     
==========================================
  Files          28       28              
  Lines        1366     1373       +7     
==========================================
+ Hits          270      273       +3     
- Misses       1062     1066       +4     
  Partials       34       34
Impacted Files Coverage Δ
pkg/standalone/list.go 8.53% <0.00%> (-0.44%) ⬇️
pkg/standalone/run.go 59.13% <100.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 717eed9...52b87a2. Read the comment docs.

yaron2
yaron2 approved these changes May 8, 2021
View reviewed changes
Copy link
Member

@yaron2 yaron2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apuzyrevsky apuzyrevsky changed the title [WIP] adding dapr-http-max-request-size parameter to cli adding dapr-http-max-request-size parameter to cli May 11, 2021
@mukundansundar
Copy link
Collaborator

mukundansundar commented May 13, 2021 •
edited
Loading

@apuzyrevsky Could you add a docs PR for this page updating the reference to include the new flag? https://docs.dapr.io/reference/cli/dapr-run/
Please target it for the v1.2 branch in docs as well.

@mukundansundar mukundansundar merged commit f22233b into dapr:master May 14, 2021
@mukundansundar mukundansundar mentioned this pull request May 21, 2021
Merged
6 tasks
anhldbk pushed a commit to anhldbk/dapr-cli that referenced this pull request Dec 22, 2021
@apuzyrevsky @artursouza @anhldbk
adding dapr-http-max-request-size parameter to cli (dapr#703)
3db6621 
Co-authored-by: Mukundan Sundararajan <musundar@microsoft.com>
Co-authored-by: Artur Souza <artursouza.ms@outlook.com>
Signed-off-by: Andy Le <anhldbk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaron2 yaron2 yaron2 approved these changes

@artursouza artursouza Awaiting requested review from artursouza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add possibility to define custom fasthttp server MaxRequestBodySize parameter to handle uploading of big files.
4 participants
@apuzyrevsky @mukundansundar @yaron2 @artursouza