Skip to content

Conversation

HaleySchuhl
Copy link
Contributor

Code to set the pcv.params.px_height and pcv.params.px_width will consider which chip dim is wider, and assign the wider chip dimension appropriately (since nano chips are 3mm by 4mm where other chips are square).

Adds onto documentation.

Type of update
Is this a:

  • feature enhancement
  • Work in progress

Associated issues
#1726 mentions that the unequal height and width

Additional context
We might consider adjusting the aspect_ratio setting, unless specified by the user, when 'nano' is selected since the chips are more rectangular than square. We did adjust this setting default (from 1.2 in find_color_card to 1.27 in detect_color_card) to allow for detection of nano cards, although a slightly larger settings might give more robust detection.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

consider which chip dim is wider, and assign the wider chip dimension appropriately. Won't matter in square color chips
@HaleySchuhl HaleySchuhl added this to the PlantCV v4.9 milestone Jul 31, 2025
@HaleySchuhl HaleySchuhl added the enhancement Enhancements to existing features label Jul 31, 2025
@github-project-automation github-project-automation bot moved this to Pull Requests in PlantCV4 Jul 31, 2025
Copy link

deepsource-io bot commented Jul 31, 2025

Here's the code health analysis summary for commits c810d7b..b7f9620. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@nfahlgren nfahlgren merged commit 2769c43 into main Aug 12, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in PlantCV4 Aug 12, 2025
@nfahlgren nfahlgren deleted the add_nano_color_card_support branch August 12, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements to existing features ready to review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants