add nano color card support in size scaling #1748
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code to set the
pcv.params.px_height
andpcv.params.px_width
will consider which chip dim is wider, and assign the wider chip dimension appropriately (since nano chips are 3mm by 4mm where other chips are square).Adds onto documentation.
Type of update
Is this a:
Associated issues
#1726 mentions that the unequal height and width
Additional context
We might consider adjusting the
aspect_ratio
setting, unless specified by the user, when 'nano' is selected since the chips are more rectangular than square. We did adjust this setting default (from 1.2 infind_color_card
to 1.27 indetect_color_card
) to allow for detection of nano cards, although a slightly larger settings might give more robust detection.For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md