Add support for automatic size scaling using color cards #1726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add to docs for auto_correct_color and detect_color_card
add helper that can set size scaling factors based on known color card chip dimensions of supported card types, and utilize in detect_color_card and therefore auto_correct_color
|
Here's the code health analysis summary for commits Analysis Summary
Code Coverage Report
|
add test that include auto size scaling factor definition
edit to inputs and code within _set_size_scale_from_chip
… the new parameter
joshqsumner
approved these changes
Jul 16, 2025
rather than as a keyword argument
also make the superscript look nicer with HTML
make color_chip_size a positional argument
This function only works for Macbeth ColorCheckers
|
@HaleySchuhl one question, why are there two pictures of the Passport in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Add support for automatic size scaling using supported color cards, by setting the
pcv.params.unit,pcv.params.px_width, andpcv.params.px_heightautomatically when acolor_chip_sizeis provided topcv.transform.detect_color_cardorpcv.transform.auto_correct_color. Current support includes "classic", "CameraTrax", or "passport" (the parameter is case insensitive and defaults toNone). Users can also set this parameter to a tuple e,g,color_chip_size=(40,40)where dimensions should be provided in millimeters.Type of update
Is this a:
Associated issues
Additional context
Does not currently support "nano" type color cards, since the rectangular chip dimensions have the added complexity of being orientation specific. This can get added in a future update, though, since we are detecting orientation through locating the white color card chip.
For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.ymlupdating.md