Skip to content

Conversation

HaleySchuhl
Copy link
Contributor

@HaleySchuhl HaleySchuhl commented Jun 13, 2025

Describe your changes
Size helper implementation in all linear & area type traits from analysis functions, also added to documentation.

Type of update
Is this a:

  • New feature or feature enhancement

Associated issues

Additional context
Scales area and linear measurements from pixels to real world measurements (e.g. millimeter) using the parameters pcv.params.px_width and pcv.params.px_height, where these parameters are the real world measurement per pixel.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@HaleySchuhl HaleySchuhl added this to the PlantCV v4.8 milestone Jun 13, 2025
@HaleySchuhl HaleySchuhl added enhancement Enhancements to existing features update Updates an existing feature/method labels Jun 13, 2025
@github-project-automation github-project-automation bot moved this to Pull Requests in PlantCV4 Jun 13, 2025
@HaleySchuhl HaleySchuhl changed the title Size helper implementation in analysis function Size helper implementation in analysis functions Jun 13, 2025
@HaleySchuhl HaleySchuhl changed the title Size helper implementation in analysis functions Size scaling implementation in analysis functions Jun 13, 2025
Copy link

deepsource-io bot commented Jun 13, 2025

Here's the code health analysis summary for commits 0961c3b..0f9751b. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@nfahlgren nfahlgren merged commit 598a347 into main Jun 24, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from Pull Requests to Done in PlantCV4 Jun 24, 2025
@nfahlgren nfahlgren deleted the size-helper-implementation branch June 24, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancements to existing features ready to review update Updates an existing feature/method
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants