Skip to content

[1/s] Add basic defs state store methods to instance #31357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[1/s] Add basic defs state store methods to instance #31357

wants to merge 2 commits into from

Conversation

benpankow
Copy link
Member

@benpankow benpankow commented Jul 25, 2025 •
edited
Loading

Summary

Adds a set of instance methods which store defs state data, to be used by components which fetch data from external APIs. This base implementation uses the run storage kvstore, in the cloud context it will use S3.

Test Plan

New unit tests.

@benpankow
Copy link
Member Author

benpankow commented Jul 25, 2025 •
edited by OwenKephart
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jul 25, 2025
Open
Draft
@benpankow benpankow force-pushed the benpankow/state-store branch 2 times, most recently from 1e4d52f to 2cc1189 Compare July 28, 2025 18:57
@OwenKephart OwenKephart force-pushed the benpankow/state-store branch 3 times, most recently from 90eb27a to 9ada543 Compare July 30, 2025 00:16
@OwenKephart OwenKephart mentioned this pull request Jul 30, 2025
Open
@OwenKephart OwenKephart force-pushed the benpankow/state-store branch from 9ada543 to a5da656 Compare July 30, 2025 23:27
@OwenKephart OwenKephart marked this pull request as ready for review July 30, 2025 23:33
@OwenKephart OwenKephart force-pushed the benpankow/state-store branch 2 times, most recently from b7aa2ed to d7fb077 Compare July 31, 2025 21:55
@OwenKephart OwenKephart force-pushed the benpankow/state-store branch from d7fb077 to 324ebb6 Compare August 5, 2025 21:31
This was referenced Aug 5, 2025
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alangenfeld alangenfeld Awaiting requested review from alangenfeld

@OwenKephart OwenKephart Awaiting requested review from OwenKephart

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@benpankow