Skip to content

ci: Add a simpler call action for Alternative CI Runners #9877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

ci: Add a simpler call action for Alternative CI Runners #9877

merged 1 commit into from
Mar 18, 2025

Conversation

gerhard
Copy link
Member

@gerhard gerhard commented Mar 17, 2025 •
edited
Loading

After all Alternative CI jobs started failing since #9673, this introduces a separate call action which is only used by these alternative CI runners. We want something simpler that has a separate lifecyle from the main call action that we use in the primary CI runners.

The problem with the current call action logging config is that GitHub Actions UI breaks, as well as the Namespace UI, so troubleshooting the source of this issue is very difficult.

I even downloaded the logs locally, which did not make it easier to find the issue. FTR:

~/Downloads/logs_35440011783 on ☁️
❯ ls -lah
total 264M
drwx------ 11 gerhard staff        352 Mar 10 19:24  .
drwxr-xr-x 59 gerhard _lpoperator 1.9K Mar 10 19:24  ..
-rw-rw-r--  1 gerhard staff        28M Nov 30  1979 '0_docs-lint-on-namespace-remote-engine _ remote-dagger-engine.txt'
-rw-rw-r--  1 gerhard staff        15M Nov 30  1979 '1_docs-lint-on-namespace-local-engine _ local-dagger-engine.txt'
-rw-rw-r--  1 gerhard staff        86M Nov 30  1979 '2_test-cli-engine-on-namespace-remote-engine _ remote-dagger-engine.txt'
-rw-rw-r--  1 gerhard staff        30M Nov 30  1979 '3_sdk-go-on-namespace-remote-engine _ remote-dagger-engine.txt'
-rw-rw-r--  1 gerhard staff        30M Nov 30  1979 '4_sdk-python-on-namespace-remote-engine _ remote-dagger-engine.txt'
-rw-rw-r--  1 gerhard staff        31M Nov 30  1979 '5_sdk-typescript-on-namespace-remote-engine _ remote-dagger-engine.txt'
-rw-rw-r--  1 gerhard staff        15M Nov 30  1979 '6_sdk-go-dev-on-namespace-local-engine _ local-dagger-engine.txt'
-rw-rw-r--  1 gerhard staff        16M Nov 30  1979 '7_sdk-typescript-dev-on-namespace-local-engine _ local-dagger-engine.txt'
-rw-rw-r--  1 gerhard staff        16M Nov 30  1979 '8_sdk-python-dev-on-namespace-local-engine _ local-dagger-engine.txt'

What's most peculiar about this issue is that the trace in Dagger Cloud doesn't show any issues:
https://v3.dagger.cloud/dagger/traces/57d1391e843c1d8a7cfb473f60c034e2

@gerhard gerhard requested a review from jedevc March 17, 2025 14:50
@TomChv
Copy link
Member

TomChv commented Mar 17, 2025

Still not sure about the name - call-2025-03-10 is not great - but I am more interested to check if this fixes the issue.

Can't you just call it call-alternative-runner?

@gerhard
Copy link
Member Author

gerhard commented Mar 17, 2025

That's a great idea @TomChv! Changing it now 👍

@gerhard gerhard force-pushed the ci-fix-local-dagger-in-alternative-runners branch from a54697e to 36e8e8d Compare March 17, 2025 15:19
jedevc
jedevc reviewed Mar 17, 2025
View reviewed changes
Copy link
Member

@jedevc jedevc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I see no reason to not just replace the old call and remove it entirely.

The only place we use it now properly is in publish.yml, I think we can just use our dagger-for-github action for that as well.

@gerhard gerhard force-pushed the ci-fix-local-dagger-in-alternative-runners branch from 36e8e8d to 10465e8 Compare March 17, 2025 15:23
@gerhard gerhard changed the title ci: Add a simpler call action ci: Add a simpler call action for Alternative CI Runners Mar 17, 2025
@gerhard
ci: Introduce a simpler call action
1696bda 
After all Alternative CI jobs started failing since #9673, this
introduces a separate `call-ci-alt-runner` action which is only used by
these alternative CI runners. We want something simpler that has a
separate lifecyle from the main `call` action that we use in the primary
CI runners.

The problem with the current `call` action logging config is that GitHub
Actions UI breaks, as well as the Namespace UI, so troubleshooting the
source of this issue is very difficult.

I even downloaded the logs locally, which did not make it easier to find
the issue. FTR:

    ~/Downloads/logs_35440011783 on ☁️
    ❯ ls -lah
    total 264M
    drwx------ 11 gerhard staff        352 Mar 10 19:24  .
    drwxr-xr-x 59 gerhard _lpoperator 1.9K Mar 10 19:24  ..
    -rw-rw-r--  1 gerhard staff        28M Nov 30  1979 '0_docs-lint-on-namespace-remote-engine _ remote-dagger-engine.txt'
    -rw-rw-r--  1 gerhard staff        15M Nov 30  1979 '1_docs-lint-on-namespace-local-engine _ local-dagger-engine.txt'
    -rw-rw-r--  1 gerhard staff        86M Nov 30  1979 '2_test-cli-engine-on-namespace-remote-engine _ remote-dagger-engine.txt'
    -rw-rw-r--  1 gerhard staff        30M Nov 30  1979 '3_sdk-go-on-namespace-remote-engine _ remote-dagger-engine.txt'
    -rw-rw-r--  1 gerhard staff        30M Nov 30  1979 '4_sdk-python-on-namespace-remote-engine _ remote-dagger-engine.txt'
    -rw-rw-r--  1 gerhard staff        31M Nov 30  1979 '5_sdk-typescript-on-namespace-remote-engine _ remote-dagger-engine.txt'
    -rw-rw-r--  1 gerhard staff        15M Nov 30  1979 '6_sdk-go-dev-on-namespace-local-engine _ local-dagger-engine.txt'
    -rw-rw-r--  1 gerhard staff        16M Nov 30  1979 '7_sdk-typescript-dev-on-namespace-local-engine _ local-dagger-engine.txt'
    -rw-rw-r--  1 gerhard staff        16M Nov 30  1979 '8_sdk-python-dev-on-namespace-local-engine _ local-dagger-engine.txt'

What's most peculiar about this issue is that the trace in Dagger Cloud
doesn't show any issues:
https://v3.dagger.cloud/dagger/traces/57d1391e843c1d8a7cfb473f60c034e2

Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
@gerhard gerhard force-pushed the ci-fix-local-dagger-in-alternative-runners branch from 10465e8 to 1696bda Compare March 17, 2025 19:17
@gerhard
Copy link
Member Author

gerhard commented Mar 17, 2025

@jedevc: Honestly, I see no reason to not just replace the old call and remove it entirely.

The only place we use it now properly is in publish.yml, I think we can just use our dagger-for-github action for that as well.

That is a good idea, and I'm keen to leave it for a separate PR since publish has a release-report with a temporary workaround which will make this PR bigger than fixing the immediate problem.

This is a good step towards removing call entirely, since it decouples Alternative CI Runners from it, and it only leaves the following depending on it:

  • benchmark.yml
  • publish.yml

@gerhard
Copy link
Member Author

gerhard commented Mar 18, 2025

Will fix testdev-cgroupsv2 separately, merging this now so that the Alternative CI Runners jobs go green ✅

@gerhard gerhard merged commit 517de5b into main Mar 18, 2025
81 of 83 checks passed
@gerhard gerhard deleted the ci-fix-local-dagger-in-alternative-runners branch March 18, 2025 12:08
kpenfound pushed a commit to kpenfound/dagger that referenced this pull request Mar 21, 2025
@gerhard @kpenfound
ci: Introduce a simpler call action (dagger#9877)
68e2b36 
After all Alternative CI jobs started failing since dagger#9673, this
introduces a separate `call-ci-alt-runner` action which is only used by
these alternative CI runners. We want something simpler that has a
separate lifecyle from the main `call` action that we use in the primary
CI runners.

The problem with the current `call` action logging config is that GitHub
Actions UI breaks, as well as the Namespace UI, so troubleshooting the
source of this issue is very difficult.

I even downloaded the logs locally, which did not make it easier to find
the issue. FTR:

    ~/Downloads/logs_35440011783 on ☁️
    ❯ ls -lah
    total 264M
    drwx------ 11 gerhard staff        352 Mar 10 19:24  .
    drwxr-xr-x 59 gerhard _lpoperator 1.9K Mar 10 19:24  ..
    -rw-rw-r--  1 gerhard staff        28M Nov 30  1979 '0_docs-lint-on-namespace-remote-engine _ remote-dagger-engine.txt'
    -rw-rw-r--  1 gerhard staff        15M Nov 30  1979 '1_docs-lint-on-namespace-local-engine _ local-dagger-engine.txt'
    -rw-rw-r--  1 gerhard staff        86M Nov 30  1979 '2_test-cli-engine-on-namespace-remote-engine _ remote-dagger-engine.txt'
    -rw-rw-r--  1 gerhard staff        30M Nov 30  1979 '3_sdk-go-on-namespace-remote-engine _ remote-dagger-engine.txt'
    -rw-rw-r--  1 gerhard staff        30M Nov 30  1979 '4_sdk-python-on-namespace-remote-engine _ remote-dagger-engine.txt'
    -rw-rw-r--  1 gerhard staff        31M Nov 30  1979 '5_sdk-typescript-on-namespace-remote-engine _ remote-dagger-engine.txt'
    -rw-rw-r--  1 gerhard staff        15M Nov 30  1979 '6_sdk-go-dev-on-namespace-local-engine _ local-dagger-engine.txt'
    -rw-rw-r--  1 gerhard staff        16M Nov 30  1979 '7_sdk-typescript-dev-on-namespace-local-engine _ local-dagger-engine.txt'
    -rw-rw-r--  1 gerhard staff        16M Nov 30  1979 '8_sdk-python-dev-on-namespace-local-engine _ local-dagger-engine.txt'

What's most peculiar about this issue is that the trace in Dagger Cloud
doesn't show any issues:
https://v3.dagger.cloud/dagger/traces/57d1391e843c1d8a7cfb473f60c034e2

Signed-off-by: Gerhard Lazu <gerhard@dagger.io>
Signed-off-by: kpenfound <kyle@dagger.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedevc jedevc jedevc approved these changes

@TomChv TomChv TomChv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gerhard @TomChv @jedevc