Skip to content

PR: Get Org Members from GitHub API #17 #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 58 commits into from
Mar 8, 2025
Merged

PR: Get Org Members from GitHub API #17 #207

merged 58 commits into from
Mar 8, 2025

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Dec 13, 2024 •
edited
Loading

This PR has all the (basic) features I've been wanting to add to the Who App
for the last decade but never found (made) time:

@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality technical A technical issue that requires understanding of the code, infrastructure or dependencies in-review Issue or pull request that is currently being reviewed by the assigned person T4h Time Estimate 4 Hours labels Dec 13, 2024
@nelsonic nelsonic mentioned this pull request Dec 13, 2024
Closed
4 tasks
This was referenced Jan 7, 2025
Closed
Closed
@nelsonic nelsonic mentioned this pull request Jan 19, 2025
Closed
1 task
@nelsonic nelsonic added in-progress An issue or pull request that is being worked on by the assigned person and removed in-review Issue or pull request that is currently being reviewed by the assigned person labels Jan 20, 2025
This was referenced Jan 20, 2025
Closed
Closed
Open
Closed
nelsonic added a commit that referenced this pull request Jan 27, 2025
@nelsonic
add GitHub Api instructions to BUILDIT.md #207
a4b8b5f
This was referenced Jan 28, 2025
Closed
Closed
Open
Closed
@nelsonic
Copy link
Member Author

nelsonic commented Feb 3, 2025

Follows: (just started collecting in the last 2 mins; limited to orgs)
image

Orgmembers:
image

Orgs:
image

Repos: (currently limited to the @dwyl repos)
image

Request Logs: (for avoiding hitting API request limits #226)
image

Stars on repos:
image

Users:
image

This is already enough to start collecting the data we want to display on the Dashboard #233
Now Need to work on Deployment! #231

@nelsonic nelsonic mentioned this pull request Feb 3, 2025
Closed
1 task
@nelsonic
add App.Follower.get_followers_from_api(org.login, true) to App.Org.b…
470fd58 
…ackfill/0 closes #227
@nelsonic
fix typo: Follower -> Follow #227
5abcf6e
@nelsonic
backfill user followers
b30c0d2
@nelsonic
create Contribs with basic functions for #20
266d94e
@nelsonic
appear to have broken something ... 🤷
fff8c65
@nelsonic
fix & refactor
20f9380
@nelsonic
finish Contribs module with tests and usage closes #20
2810f6b
@nelsonic
dont overwrite users with incomplete data!! #86
9492052
@nelsonic
ignore response of create_incomplete_user_no_overwrite/1 for error ca…
de5e3a7 
…ses; closes #243
@nelsonic
init work on dashboard #233
fc87e95
@nelsonic
adapt the tailadmin analytics metrics to our needs #233 (comment)
46dac0f
@nelsonic
add unhappy path test and handler function for #244
0bf51bc
@nelsonic
3 failing tests ... #244
c639a5e
@nelsonic
fix faling tests (adds error handling for #244)
466dbfa
@nelsonic
comment-out unused code. 100% cov closes #244
2242738
@nelsonic nelsonic force-pushed the get-members-from-rest-api-issue-#1 branch from 56eaa99 to 2242738 Compare February 27, 2025 11:39
@nelsonic nelsonic mentioned this pull request Feb 27, 2025
Closed
@nelsonic
Copy link
Member Author

nelsonic commented Mar 8, 2025

This PR is getting too big. 💭
It already includes many of the features I want. ✅
Just not the Dashboard #233 📈
Let's ship this and then work on just the Dashboard. 👌

@nelsonic nelsonic added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Mar 8, 2025
@nelsonic nelsonic moved this from In progress to Awaiting Feedback/Review in Nelson's List Mar 8, 2025
@nelsonic nelsonic moved this to ⏳Awaiting Review in dwyl app kanban Mar 8, 2025
asntc
asntc approved these changes Mar 8, 2025
View reviewed changes
Copy link
Member

@asntc asntc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed. :shipit:

@asntc asntc merged commit cb121de into main Mar 8, 2025
1 check passed
@github-project-automation github-project-automation bot moved this from Awaiting Feedback/Review to Done in Nelson's List Mar 8, 2025
@github-project-automation github-project-automation bot moved this from ⏳Awaiting Review to ✅ Done in dwyl app kanban Mar 8, 2025
@asntc asntc deleted the get-members-from-rest-api-issue-#1 branch March 8, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asntc asntc asntc approved these changes

Assignees

@asntc asntc

Labels
awaiting-review An issue or pull request that needs to be reviewed enhancement New feature or enhancement of existing functionality T4h Time Estimate 4 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
Nelson's List
Status: Done
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelsonic @asntc