Sink service client & unit tests #639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 2, 2021 23:17
Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
|
@wjuan-AFK please review and assign back to me once done. |
wjuan-AFK
reviewed
Mar 11, 2021
mum4k
requested changes
Mar 11, 2021
added 6 commits
March 12, 2021 08:32
…sink-client Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
mum4k
reviewed
Mar 12, 2021
api/sink/sink.proto
Outdated
| @@ -0,0 +1,37 @@ | |||
| syntax = "proto3"; | |||
|
|
|||
| package nighthawk.sink; | |||
There was a problem hiding this comment.
In our last discussion about namespaces, we ended up on having just a single namespace for Nighthawk's future code. Do we have a good reason to introduce the new namespace here?
mum4k
previously approved these changes
Mar 12, 2021
|
@oschaaf just one remaining question about the new namespace. |
Signed-off-by: Otto van der Schaaf <ovanders@redhat.com>
mum4k
approved these changes
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the proto definition for the sink service plus a client implementation and test.
Signed-off-by: Otto van der Schaaf ovanders@redhat.com