Improving CI performance #3251
Merged
Improving CI performance #3251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Looks excellent. It seems the NodeJS and Python OSX builds are still running in the PR, can we disable those as well for PRs? |
Mytherin
pushed a commit
that referenced
this pull request
Oct 13, 2024
Integer division in C++ rounds towards 0, not down. This was impacting all resolutions hour and below. fixes: duckdblabs/duckdb-internal#3251
Mytherin
added a commit
that referenced
this pull request
Oct 13, 2024
Integer division in C++ rounds towards 0, not down. This was impacting all resolutions hour and below. fixes: duckdblabs/duckdb-internal#3251
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 17, 2024
Internal duckdb/duckdb#3251: DateDiff Across Epoch (duckdb/duckdb#14338)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Oct 17, 2024
Internal duckdb/duckdb#3251: DateDiff Across Epoch (duckdb/duckdb#14338) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr contains a few changes to the CI that should bring a decent reduction in overal CI runner load.
Potential further improvements
I could move tools/odbc and tools/jdbc into separate yml files and add similar optimization to only run the relevant ci for those directories. I could also add this to this PR?
For more drastic changes in CI runner load we could consider running the CI only on a specific subset pull_request events. For example we could only run the CI on the pull_request.opened and and pull_request.review_requested events (see github docs), which would mean that CI will run automatically on the initial pr open, but for the ci to be rerun when the author has made changes, the author has to explicitly request a review, which will then trigger the CI. However, whether this is a development workflow we want is up for discussion. I'd say it makes sense to wait out this pr and see if CI queue/run times improve enough to leave it as is.