Issue #600: Improve DATEXXX #2095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 2, 2021 12:24
Now that there are structs for all temporal types, we can dispense with the separate structs and lose some duplicated code.
Special case constant date part strings.
Special case constant part string. Refactor to look like the other part functions.
Mytherin
reviewed
Aug 3, 2021
Remove constant optimisation in DATEPART because the translator handles it. Tweak Quater extraction to use Date::Convert.
|
I expect removing the constant optimisation should implode the coverage statistics... |
Mytherin
reviewed
Aug 4, 2021
Add missing DATE_TRUNC constant tests. Fix DATE_TRUNC ms/µs confusion. Add missing YEARWEEK date part and tests.
|
Thanks, looks great! |
hawkfish
added a commit
to hawkfish/duckdb
that referenced
this pull request
May 21, 2024
Disallow streaming window execution for DISTINCT aggregates. fixes: duckdblabs/duckdb-internal#2095
Mytherin
added a commit
that referenced
this pull request
May 21, 2024
Internal #2095: Streaming Window Structs
hawkfish
added a commit
to hawkfish/duckdb
that referenced
this pull request
May 26, 2024
Disallow streaming window execution for DISTINCT aggregates. fixes: duckdblabs/duckdb-internal#2095
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the code and add special cases for the common situation where the part is a constant string.