Skip to content

Conversation

hawkfish
Copy link
Contributor

Disallow streaming window execution for DISTINCT aggregates.

fixes: duckdblabs/duckdb-internal#2095

Disallow streaming window execution for DISTINCT aggregates.

fixes: duckdblabs/duckdb-internal#2095
@hawkfish hawkfish requested a review from lnkuiper May 21, 2024 15:59
@hawkfish hawkfish requested a review from Mytherin May 21, 2024 15:59
@hawkfish
Copy link
Contributor Author

I moved the test function to the physical operator because it knows what it can handle...

Copy link
Collaborator

@Mytherin Mytherin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@Mytherin Mytherin merged commit ea3a7a7 into duckdb:main May 21, 2024
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request May 21, 2024
Merge pull request duckdb/duckdb#12173 from hawkfish/streaming-distinct
Merge pull request duckdb/duckdb#12176 from Mytherin/releaseassertionstimeout
@hawkfish hawkfish deleted the streaming-distinct branch May 22, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants