Enable clang-tidy on headers and fix all headers to conform to our clang-tidy rules #11376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, yea I remember this issue/PR addressing this problem |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Mar 30, 2024
Merge pull request duckdb/duckdb#11376 from Mytherin/clangtidyfixes Merge pull request duckdb/duckdb#11379 from samansmink/fix-https-ci-macos Merge pull request duckdb/duckdb#11368 from pfarndt/blob-fix Merge pull request duckdb/duckdb#11366 from szarnyasg/readme-logo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an old issue where clang-tidy was not run on headers because of an incorrect header filter regex