Fix HeaderFilterRegex in .clang-tidy #9614
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tishj Please check this :) |
|
Thanks for the PR! While I agree with the change and we should run clang-tidy on the headers, this is not mergable right now as this leads to the CI failing. The change would have to happen alongside fixing all of the tidy checks in the headers. |
|
Yea I agree, I encouraged them to make this draft PR to highlight the problem. So this PR should be seen as an issue submission, not really a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #9537, the
HeaderFilterRegexin.clang-tidyonly matchesre2.h. This results in almost all header files not checked by clang-tidy.I runned
make tidy-checkafter fixing it and there are a lot of errors now.