Avoid rchk unhappiness #1022
Closed
Avoid rchk unhappiness #1022
+184
−179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
hawkfish
added a commit
to hawkfish/duckdb
that referenced
this pull request
Jan 9, 2024
Time arithmetic is strange and wraps, so we can't use simple arithmetic to compute the RANGE boundaries. Instead, we bind to epoch + time, which will not wrap. fixes: duckdblabs/duckdb-internal#1022
Mytherin
added a commit
that referenced
this pull request
Jan 15, 2024
Internal #1022: Window TIME RANGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by moving ~unique_ptr() before protect/unprotect code.
https://raw.githubusercontent.com/kalibera/cran-checks/master/rchk/results/duckdb.out