Dynamic Syntax Highlighting in Shell #1001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e "SQLite Version" from shell. Write history to ".duckdb_history", instead of to ".sqlite_history", to avoid conflicts with SQLite shell.
…inal-color-code], .constant [color], .constantcode [terminal-color-code]
…F8, which caused the decode in this test to fail. Just do a binary search in the file now.
hawkfish
added a commit
to hawkfish/duckdb
that referenced
this pull request
Jan 10, 2024
Add explicit sorting and the partition key to the window test.
Mytherin
added a commit
that referenced
this pull request
Jan 11, 2024
Internal #1001: SEM Test Determinism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds syntax highlighting to the SQLite shell for Linux and MacOS. The system runs the lexer on the current line of user input, and highlights keywords as bold green, and numeric/string constants as yellow. The text is highlighted as you are typing. For now this is disabled on Windows.
The PR also sets the following options as default in the shell:
See the image below for a preview.
For now the colors are fixed, but should probably be customizable.
Would appreciate it if any shell users would test this PR and submit feedback/report issues :)