Issue #9869: Strptime Week Start #9890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no weekday is specified for %W, use Monday, not Sunday as the default. This is less confusing, and since Python doesn't support it, we get to make the rules. fixes: duckdb#9869 fixes: duckdblabs/duckdb-internal#838
Missing file from commit.
Mytherin
reviewed
Dec 5, 2023
| @@ -90,9 +90,9 @@ SELECT try_strptime('30', '%U'), strftime('1900-07-29'::DATE, '%U') | |||
| 1900-07-29 00:00:00 30 | |||
|
|
|||
| query II | |||
| SELECT try_strptime('30', '%W'), strftime('1900-07-29'::DATE, '%W') | |||
| SELECT try_strptime('30', '%W'), strftime('1900-07-23'::DATE, '%W') | |||
There was a problem hiding this comment.
Can we also add a test with %U (which results in WEEK_NUMBER_PADDED_SUN_FIRST)?
There was a problem hiding this comment.
The date changed because we are now using the first day of the week as a weekday default instead of Sunday. It actually tests the change!
krlmlr
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Dec 14, 2023
Merge pull request duckdb/duckdb#9890 from hawkfish/strptime-week
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no weekday is specified for %W, use Monday, not Sunday as the default.
This is less confusing, and since Python doesn't support it, we get to make the rules.
fixes: #9869
fixes: duckdblabs/duckdb-internal#838