Skip to content

Create streaming result from a prepared statement. #9802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2023
Merged

Create streaming result from a prepared statement. #9802

merged 2 commits into from
Nov 28, 2023

Conversation

Giorgi
Copy link
Contributor

@Giorgi Giorgi commented Nov 25, 2023

Implements #9784

@github-actions github-actions bot marked this pull request as draft November 25, 2023 15:35
@Giorgi Giorgi marked this pull request as ready for review November 25, 2023 15:36
@Giorgi
Copy link
Contributor Author

Giorgi commented Nov 25, 2023

Not sure why Java JDBC / Java Windows (arm64) failed.

@Tishj
Copy link
Contributor

Tishj commented Nov 26, 2023

Not sure why Java JDBC / Java Windows (arm64) failed.

I think that's unrelated, has been failing on different PRs as well 👍

@Tishj
Copy link
Contributor

Tishj commented Nov 26, 2023 •
edited
Loading

Isn't this pretty much just combining these two steps into one?

duckdb_pending_prepared_streaming
duckdb_execute_pending

#6318

@Giorgi
Copy link
Contributor Author

Giorgi commented Nov 26, 2023

According to documentation duckdb_pending_prepared_streaming returns a pending result represents an intermediate structure for a query that is not yet fully executed so I need to call duckdb_pending_execute_task until duckdb_pending_execution_is_finished returns true right? Or can I skip duckdb_pending_execute_task calls and call directly duckdb_execute_pending?

@Giorgi
Copy link
Contributor Author

Giorgi commented Nov 26, 2023

Even if I can use duckdb_pending_prepared_streaming followed by duckdb_execute_pending, it is weird for API consumers to have to use two different sets of interfaces to switch between streaming and non-streaming result.

@Mytherin Mytherin merged commit 4a788da into duckdb:main Nov 28, 2023
@Mytherin
Copy link
Collaborator

Thanks!

krlmlr added a commit to duckdb/duckdb-r that referenced this pull request Dec 14, 2023
@krlmlr
chore: Update vendored sources to duckdb/duckdb@4a788da
fa088ce 
Merge pull request duckdb/duckdb#9802 from Giorgi/master
Merge pull request duckdb/duckdb#9811 from Tishj/pandas_analyzer_skip_nulls
Merge pull request duckdb/duckdb#9827 from Mytherin/cifix
Merge pull request duckdb/duckdb#9826 from carlopi/verboseerror
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Giorgi @Tishj @Mytherin